After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 377144 - Branding on the System tab
Branding on the System tab
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
2.17.x
Other All
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-19 21:01 UTC by Corey Burger
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sys_mon_branding.patch (2.90 KB, patch)
2007-01-22 00:31 UTC, Luca Cavalli
committed Details | Review
side.xcf (28.99 KB, image/x-xcf)
2007-01-22 00:33 UTC, Luca Cavalli
  Details
side.png (3.35 KB, image/png)
2007-01-22 00:33 UTC, Luca Cavalli
  Details
sys_mon_themed.png (57.33 KB, image/png)
2007-01-22 00:34 UTC, Luca Cavalli
  Details
new mockup inspired by Gnome splash screen (68.27 KB, image/png)
2007-01-22 13:41 UTC, Andrea Paiola
  Details

Description Corey Burger 2006-11-19 21:01:17 UTC
There is now GNOME branding on the system tab. This is a bad thing for the following reasons:

1. Looks out of place in non-blue themes
2. Branding for GNOME outside the about-gnome box is bad
3. Is likely to be patched out by distributors, meaning more patches
Comment 1 Benoît Dejean 2006-11-20 12:08:42 UTC
3. it's meant for that
Comment 2 Corey Burger 2006-11-20 17:47:28 UTC
Benoit,

I am a little confused. Do you mean that the system tab is meant for branding?
Comment 3 Benoît Dejean 2006-11-20 17:55:56 UTC
As the system info tab displays the distribution of the computer, what's wrong with adding a little logo ?

The patch comes from novell. I had a friend of my do a gnome logo to replace the novell one. Packagers are free to replace it. Do you think it's a bad idea to display the distribution logo ?
Comment 4 Corey Burger 2006-11-20 18:15:25 UTC
I am not a big fan of excessive branding, as I like "ego-less" computers. There is  place for this kind of branding, the about box. Note that I am only talking about the image, not the quite useful text beside it.
Comment 5 Benoît Dejean 2006-11-22 11:05:43 UTC
I don't know what to do : i think it's nice to get the logo of the distribution next to the distribution name but i understand your point of view.
Comment 6 Alan Horkan 2007-01-18 17:13:19 UTC
> 1. Looks out of place in non-blue themes

aka *breaks accessibility*

please remove as soon as possible

(not to mention this kind of branding is annoying and unhelpful)
Comment 7 Matthias Clasen 2007-01-18 18:54:10 UTC
I strongly agree that this should be removed.
Comment 8 Benoît Dejean 2007-01-18 19:24:37 UTC
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.
Comment 9 Alan Horkan 2007-01-19 05:16:29 UTC
Thanks Benoit.  Sorry to be the bearer of bad news. 
Gnome branding has always been a hugely difficult subject, it is amazing quite how complicated it can be to develop even something like gnome-about which seems terribly simple.  
Comment 10 Luca Cavalli 2007-01-22 00:30:59 UTC
I'm reopening the bug, since I think that branding the system tab is a nice idea. I'm probably too late, since we are in UI freeze and my patch seems to have a little refresh problem (try move another window over system monitor one). If someone can spot the problem, please fix it :)
Comment 11 Luca Cavalli 2007-01-22 00:31:37 UTC
Created attachment 80841 [details] [review]
sys_mon_branding.patch
Comment 12 Luca Cavalli 2007-01-22 00:33:06 UTC
Created attachment 80842 [details]
side.xcf

Background stripes are in a hidden layer.
Comment 13 Luca Cavalli 2007-01-22 00:33:28 UTC
Created attachment 80843 [details]
side.png
Comment 14 Luca Cavalli 2007-01-22 00:34:06 UTC
Created attachment 80844 [details]
sys_mon_themed.png
Comment 15 Corey Burger 2007-01-22 07:33:15 UTC
Yes, the new colour stuff does solve the theme clashing issue[1]. However, it does not solve the "branding in inappropriate places" problem. To me, any branding in the system tab is wrong. The appropriate place for that is the About box and the default browser homepage.

[1] http://log.emmanuelebassi.net/archives/2007/01/wonderboy/
Comment 16 Benoît Dejean 2007-01-22 09:25:52 UTC
Your patch is so great ! I am definitely looking after someone from the release-team (?) to clearly state about this branding issue. But it's too late because of the freeze.

(Moreover, vuntz asked for the GNOME version to be displayed in http://bugzilla.gnome.org/show_bug.cgi?id=399069 so having a logo makes some sense)
Comment 17 Emmanuele Bassi (:ebassi) 2007-01-22 09:43:03 UTC
we are not in the UI freeze yet: it'll be in act tonight at 00:00 UTC.  and even in that case, you can request a break from the release-team.
Comment 18 Michael Monreal 2007-01-22 10:15:22 UTC
For me, having this branding in place seems to be the right thing because this page of the system monitor is just about this, information about the system.

I would even go one stem further and include GNOME release info here (a GNOME section between OS and Hardware) and include all the info from about-gnome here (which is basicly: Version and Build Date). This could even replace the gnome-about, as it is really not that helpful and the info given there would better be given on a web page (well most of the program is web links anyway)
Comment 19 Pacho Ramos 2007-01-22 10:26:54 UTC
This branding looks great :-), I think that this should be added (with the latest patch) in gnome 2.18.

Thanks a lot :-)
Comment 20 Benoît Dejean 2007-01-22 10:38:29 UTC
Is this patch OK with accessibility ?
Comment 21 Andrea Paiola 2007-01-22 13:41:11 UTC
Created attachment 80892 [details]
new mockup inspired by Gnome splash screen
Comment 22 Luca Cavalli 2007-01-31 22:07:16 UTC
The patch was committed, thanks. I'm going to close the bug.