After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357970 - Don't call deprecated GLib / GDK functions (continued)
Don't call deprecated GLib / GDK functions (continued)
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.8.x (obsolete)
Other Linux
: Urgent normal
: ---
Assigned To: Harish Krishnaswamy
Evolution QA team
evolution[codecleanup]
Depends on:
Blocks:
 
 
Reported: 2006-09-27 14:14 UTC by Matthew Barnes
Modified: 2006-12-04 18:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (54.65 KB, patch)
2006-09-27 16:09 UTC, Matthew Barnes 		accepted-commit_now Details | Review

Description Matthew Barnes 2006-09-27 14:14:14 UTC 
This is a follow up to bug #352450.  I found a bunch more deprecated GLib and GDK symbols that Evolution is still using.  I must've forgotten to recompile after fixing the first wave of compilation errors in the previous bug.

To reproduce:
$ CFLAGS="-DG_DISABLE_DEPRECATED=1 -DGDK_PIXBUF_DISABLE_DEPRECATED=1
> -DGDK_DISABLE_DEPRECATED=1" ./configure; make
Comment 1 André Klapper 2006-09-27 14:43:26 UTC 
$ CFLAGS="-DG_DISABLE_DEPRECATED=1 -DGDK_PIXBUF_DISABLE_DEPRECATED=1 -DGDK_DISABLE_DEPRECATED=1" ./configure; make

okay...
Comment 2 Matthew Barnes 2006-09-27 16:09:59 UTC 
Created attachment 73503 [details] [review]
Proposed patch

This patch, along with the patch in bug #357216, should allow evolution to compile with deprecated GLib and GDK symbols disabled as shown above.
Comment 3 Paolo Borelli 2006-09-28 13:07:32 UTC 
I am always curious of cleanups throughout the gnome stack, so I noticed this bug being filed. Great stuff. What about adding this to configure.in ?


AC_ARG_ENABLE(deprecations,
              [AC_HELP_STRING([--enable-deprecations],
                              [warn about deprecated usages [default=no]])],,
              [enable_deprecations=no])

if test "x$enable_deprecations" = "xyes"; then
   DISABLE_DEPRECATED_CFLAGS="\
-DG_DISABLE_DEPRECATED \
-DGDK_DISABLE_DEPRECATED \
-DGTK_DISABLE_DEPRECATED \
-DGDK_PIXBUF_DISABLE_DEPRECATED \
-DGNOME_DISABLE_DEPRECATED"
   AC_SUBST(DISABLE_DEPRECATED_CFLAGS)
fi
Comment 4 Harish Krishnaswamy 2006-09-28 17:45:33 UTC 
Mathew : thanks for the updated patch. 
Paolo : Thanks for the configure.in snippet. I agree this is a good (must) thing to have.
I do not have access to my workarea atm...but will review/test this tomorrow and ensure it hits the 2.8.1 release.
Comment 5 Matthew Barnes 2006-09-29 01:43:38 UTC 
(In reply to comment #3)

Great idea, although we're not quite ready for GTK_DISABLE_DEPRECATED or GNOME_DISABLE_DEPRECATED.  I'm working on that.
Comment 6 Harish Krishnaswamy 2006-12-04 05:30:11 UTC 
Oops.. I missed this for 2.8.1. 
Looks good to commit. thanks for the patch. Yes, it is too early to do a complete sweep, but this patch is a way forward. 
Matthew: Thanks again for this patch and your continued contribution.
Comment 7 Matthew Barnes 2006-12-04 18:06:34 UTC 
Committed to HEAD and gnome-2-16 branch.

I opened bug #382288 to address Paolo's suggestion.