GNOME Bugzilla – Bug 357216
Don't use deprecated GdkFont
Last modified: 2013-09-10 14:04:48 UTC
When I was fixing bug #352450, I shied away from fixing some widgets that are still using GdkFont because it would involve changing some of their GObject properties. I had a second look at this and realized that these properties are unused, and some of them are obsolete. So here's what I did: ETableFieldChooserItem - Replaced "GdkFont *font" with "PangoFontDescription *font_desc". ETableGroupContainer - Replaced "GdkFont *font" with "PangoFontDescription *font_desc". ETableHeaderItem - Replaced "GdkFont *font" with "PangoFontDescription *font_desc". - Renamed the "fontset" property to "font-desc", and changed the type from a string to a PangoFontDescription object. - Removed the now unused ethi_font_load() function. EEntry - There are three font properties: "font", "fontset", and "font_gdk" - All of the get and set handlers for these properties simply forward to equivalent properties in entry->item (an EText object), but there are no (longer?) such properties in EText. So I removed them from EEntry. Again, the properties I changed are not currently used in Evolution. These changes allow Evolution to build with deprecated GDK symbols disabled: $ export CFLAGS="-DGDK_DISABLE_DEPRECATED=1" $ ./configure $ make --- As an aside, the GObject properties in the Evolution widgets I looked at appear to be in a state of disrepair. For example, I saw several properties being registered as G_PARAM_READWRITE but lacking either a read or write handler. In other cases such as EEntry, read and write handlers are forwarding requests to non-existant properties in other objects. Evolution's widgets should be audited to make sure the properties and signals they define are still relevant. I'll add this to my list of "housekeeping" chores and file a separate bug report when I get to it.
Created attachment 73231 [details] [review] Proposed patch
great stuff like always, thanks!
This patch is really awesome :-). Srag : Can you pl. look into this and approve the patch for absorption ?
Ping: any progress on reviewing this?
Hey Matthew, looks find to me. Please commit.
Committed to HEAD.