After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349189 - LADSPA gstsignalprocessor.c: line 408: assertion failed: (self->pending_in != 0)
LADSPA gstsignalprocessor.c: line 408: assertion failed: (self->pending_in != 0)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 347676 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-07-29 16:13 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2006-08-04 09:11 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Stefan Sauer (gstreamer, gtkdoc dev) 2006-07-29 16:13:26 UTC
> grep -Hn "pending_in" *.c
gstsignalprocessor.c:328:  g_return_if_fail (self->pending_in == 0);
gstsignalprocessor.c:408:  g_assert (self->pending_in != 0);
gstsignalprocessor.c:410:  self->pending_in--;
gstsignalprocessor.c:412:  if (self->pending_in == 0) {
gstsignalprocessor.c:469:  if (self->pending_in != 0) {
gstsignalprocessor.c:558:  if (self->pending_in == 0) {

where do we miss the 'self->pending_in++' ?
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2006-07-29 16:33:27 UTC
additional tasks:
* check other FIXME: in the source too
* comment the purpose of the class-members briefly
Comment 2 Tim-Philipp Müller 2006-07-29 17:54:39 UTC
*** Bug 347676 has been marked as a duplicate of this bug. ***
Comment 3 Andy Wingo 2006-07-31 09:27:46 UTC
I think what it's missing is at the end of signal_processor_process(), there should be a self->pending_in = klass->num_audio_in;. However I think there are probably problems with asserts in the case of plugins with no audio inputs or with no audio outputs.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2006-07-31 19:27:11 UTC
still get:

** ERROR **: file gstsignalprocessor.c: line 411 (gst_signal_processor_pen_buffer): assertion failed: (self->pending_in != 0)

the change needs to be somewhere else.
Comment 5 Andy Wingo 2006-08-04 09:11:25 UTC
Fixed in today's commit.