GNOME Bugzilla – Bug 348630
dialog migration from gnopernicus to orca
Last modified: 2006-08-07 09:49:26 UTC
orca is currently proposed for inclusion in gnome 2.16 by a considerable consensus including the gnopernicus team. Because the AT Technology Preferences Dialog's code currently expects gnopernicus, a change to the dialog's internals is required. There is also a question of migration paths. To date the orca team has received no customer requests for data or configuration migration, so it is not clear that this is a real issue. For existing desktop users who are currently using gnopernicus, there are two questions: 1) under what should orca be started instead of gnopernicus after 2.16 is installed? 2) what notification does the user need that this change has taken place?
Created attachment 69574 [details] [review] patch to substitute 'orca' for 'gnopernicus' when present on system, when the AT Prefs dialog is run.
See also bug 348643, for a back-compat patch to gnome-session (relevant to the case of a fresh 2.16 install with a user's home dir shared with a 2.14 config).
I have a question regarding this patch and its impact on FC6: do we really want to get rid of the gnopernicus-specific gconf keys (i.e., the ones gnopernicus uses when it starts)? If FC6 will be shipping gnopernicus and not orca because of their feature freeze deadline, it seems as though we want to make sure those keys are written.
The patch was missing the necessary changes to main.c (diff scope error, probably). I will attach the complete patch now.
Created attachment 70082 [details] [review] patch which migrates the at-properties dialog to orca. patch builds OK but Will, please test it. My build/run env is pretty messed up ATM so I am unable to confirm all the behaviors.
I think these lines cause the UI to be a bit aggressive: + if (exec_name && !strcmp (exec_name, "orca")) { + startup_state->enabled.magnifier = TRUE; + startup_state->enabled.screenreader = TRUE; The problem is that once you select one or the other of the mag/screenreader check boxes, the other gets checked. After that, you can no longer unselect them.
Created attachment 70091 [details] [review] Patch to substitute orca for gnopernicus when present on system, when the AT prefs dialog is run After testing with the previous patches, it was determined that one would get into a situation where they would check one or the other of magnifier/screenreader and the other would automatically become selected. Once this happened, one could not deselect them. The main cause of that is that the disambiguation of whether the magnifier or screen reader are selected is based upon the gnopernicus settings keys for speech, braille, and magnifier. This patch keeps the gnopernicus keys manipulation for the purposes of disambiguation, and also provides a compatibility feature where gnopernicus will still be selected/used if orca is not present in the user's path. Preference is given to orca, however, if it is available. The ultimate solution is to rethink the overall strategy for a potentially even larger set of screen reader choices for GNOME 2.18 - that will come with the redesign of the accessibility preferences GUI that we agreed to postpone to GNOME 2.18. I feel this patch provides a compatible migration path for GNOME 2.16.
This last patch looks good to me. Sebastien, what do you think?
Just to add more - Bill and I just talked and we agree the patch is acceptable for GNOME 2.16. I've tested the patch from comment #7 pretty thoroughly with various combinations of gnopernicus and orca being installed or not installed, and it works as expected. If you can get this in for the Beta2 tarballs this coming Monday, it would be great.
Patch looks fine to me too, feel free to commit
Patch committed to HEAD, thanks