GNOME Bugzilla – Bug 348643
orca back-compat for session AT startup
Last modified: 2006-08-07 14:33:50 UTC
orca is proposed for inclusion in 2.16 as the screen reading technology, by a consensus including the gnopernicus team. However in a new 2.16 install with a shared user directory left over from 2.14, the old legacy screenreader AT startup would fail since it points to 'gnopernicus'. The small attached patch provides fallback/migration behavior for the rare cases where the user's home directory exists already but the rest of the desktop operating environment is a 'fresh install'.
Created attachment 69583 [details] [review] patch to preserve compat with legacy gconf value of exec_ats
Created attachment 69644 [details] [review] patch to preserve compat with legacy gconf value of exec_ats
(thanks Will for noting that the previous patch was for the related bug. The new patch solves the gnome-session side of the issue).
Hi All - hold off on this patch for a bit. It's incomplete (main.c needs updating as well to reflect the AtStartupState struct changes).
No, this patch is fine. Will's talking about a different bug.
FYI the 'other bug' is 648630, and the problem seems to be that the original diff didn't include the change to main.c. I have updated the bugzilla patch to include that part of the diff. Will, please confirm that this patch (gnome-session patch, 348643) is correct, for the benefit of the maintainers :-)
Created attachment 70089 [details] [review] Patch that does the same as the previous, but really runs orca. After testing, I determined that the previous patch was flawed: it attempted to run gnopernicus yet again rather than using orca (i.e., it reused 'exec_string' instead of the newly created 's'). This new patch will really run orca in the event that gnopernicus is not found (assuming orca is installed).
I committed a modified patch. Thanks!