After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345499 - Close button in menu is too thin
Close button in menu is too thin
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on: 345498
Blocks:
 
 
Reported: 2006-06-21 00:07 UTC by Baptiste Mille-Mathias
Modified: 2006-08-20 20:01 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
die thin pixmap, I want you to die for 4 years :) (258 bytes, image/png)
2006-06-21 00:08 UTC, Baptiste Mille-Mathias
  Details
make libwnck use the gtk_stock_close icon (2.38 KB, patch)
2006-06-24 12:45 UTC, Baptiste Mille-Mathias
none Details | Review
New stock_delete.png (220 bytes, image/png)
2006-08-18 20:47 UTC, Baptiste Mille-Mathias
  Details

Description Baptiste Mille-Mathias 2006-06-21 00:07:28 UTC
+++ This bug was initially created as a clone of Bug #345498 +++

the close button in the contextual libwnck menu is too thin regarding the other icon (minimize, maximize).
I attach an update pixmap right now.
Comment 1 Baptiste Mille-Mathias 2006-06-21 00:08:06 UTC
Created attachment 67755 [details]
die thin pixmap, I want you to die for 4 years :)
Comment 2 Vincent Untz 2006-06-21 04:34:41 UTC
Let's make this one depend on the metacity bug so that we commit both at the same time.
Comment 3 Elijah Newren 2006-06-21 14:03:48 UTC
Why not use stock_close.png so that it's consistent with the icon shown for the file->quit action (and possible Quit buttons)?
Comment 4 Baptiste Mille-Mathias 2006-06-21 14:12:07 UTC
I assume you talk about the name of the file. 
I totally agree to rename it to stock_close; I wondered yesterday while browsing the source, why this name was choose.
Comment 5 Elijah Newren 2006-06-21 14:32:51 UTC
No, I meant that why create a new pixmap when gtk+ already has one (possibly themed?) specifically for closing the application that is used on both close buttons and sometimes on the file->quit action.  Why not just reuse that one?
Comment 6 Vincent Untz 2006-06-21 19:03:33 UTC
Maybe there was one reason when Havoc did this. Let's try a ping :-)
Havoc: ping?
Comment 7 Baptiste Mille-Mathias 2006-06-24 12:45:50 UTC
Created attachment 67935 [details] [review]
make libwnck use the gtk_stock_close icon

From a total coding newbie, it's works fine. I'm waiting for your comments.
Comment 8 Baptiste Mille-Mathias 2006-08-18 20:47:10 UTC
Created attachment 71189 [details]
New stock_delete.png

It was decided on release-team mailing list the new pixmap can be applied.
Comment 9 Pascal Terjan 2006-08-20 19:53:14 UTC
committed your pixmap
Comment 10 Baptiste Mille-Mathias 2006-08-20 20:01:28 UTC
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.