After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345498 - Close button in menu is too thin
Close button in menu is too thin
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
: 135770 (view as bug list)
Depends on:
Blocks: 345499
 
 
Reported: 2006-06-21 00:03 UTC by Baptiste Mille-Mathias
Modified: 2007-05-05 09:07 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
this bug ennoy me for ... 4 years at least (258 bytes, image/png)
2006-06-21 00:04 UTC, Baptiste Mille-Mathias 		  Details
Patch that use GTK_STOCK_CLOSE icon (2.17 KB, patch)
2006-06-24 10:09 UTC, Baptiste Mille-Mathias 		none Details | Review
New stock_delete.png (220 bytes, image/png)
2006-08-18 20:48 UTC, Baptiste Mille-Mathias 		  Details

Description Baptiste Mille-Mathias 2006-06-21 00:03:43 UTC 
the close button in the metacity menu is too thin regarding the other icon (minimize, maximize).
I attach an update pixmap right now.
Comment 1 Baptiste Mille-Mathias 2006-06-21 00:04:58 UTC 
Created attachment 67754 [details]
this bug ennoy me for ... 4 years at least
Comment 2 Baptiste Mille-Mathias 2006-06-24 10:06:56 UTC 
regarding the comment 5 in bug 345499, I've created a patch that make metacity use the GTK_STOCK_CLOSE icon. Now we have a themed Close button in metacity menu :) 
it's a little bit off-topic, but could now there visual difference between the close icon and maxiximise/minimize icons. Would it be possible to add such icon in gtk stock icons to have a consistent behaviour ?
Comment 3 Baptiste Mille-Mathias 2006-06-24 10:09:43 UTC 
Created attachment 67929 [details] [review]
Patch that use GTK_STOCK_CLOSE icon

First patch for metacity, wouhou
Comment 4 Baptiste Mille-Mathias 2006-07-26 07:05:53 UTC 
I tested the patch but the result doesn't look great, because the close button is themed and not the other icons (maximized and minimized).
So we have 2 options:
- use a pixmap as provided in comment #1
- create a GTK stock icon for maximized and minimized, but I'm not sure this a good option

The same comment applies also for bug 345499
Comment 5 Baptiste Mille-Mathias 2006-08-18 20:48:19 UTC 
Created attachment 71190 [details]
New stock_delete.png

It was decided on release-team mailing list the new pixmap can be commited in cvs.
Comment 6 Thomas Thurman 2006-08-19 01:29:10 UTC 
This should probably be dealt with at the same time as bug 135770.
Comment 7 Pascal Terjan 2006-08-20 19:53:37 UTC 
committed your pixmap
Comment 8 Baptiste Mille-Mathias 2006-08-20 20:01:19 UTC 
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.
Comment 9 Baptiste Mille-Mathias 2007-05-05 09:07:30 UTC 
*** Bug 135770 has been marked as a duplicate of this bug. ***