GNOME Bugzilla – Bug 339966
Find toolbar is too large (and ugly)
Last modified: 2006-07-30 01:32:18 UTC
The evince find toolbar is way too large (height) and shows two separators next to each other. I'll attach a screenshot to illustrate this. Epiphany has a very nice find toolbar that looks pretty good. I'll attach a screenshot to illustrate this, too. Evince should feature the same toolbar as Epiphany does.
Created attachment 64423 [details] Find toolbar from Evince This is how it looks in Evince.
Created attachment 64424 [details] Find toolbar from Epiphany This is how it looks in Epiphany. Much nicer, don't you think?
Should be easy to port epiphany/src/ephy-find-toolbar over to evince :)
Patch is welcome :) I'll happily commit it.
Created attachment 66309 [details] [review] Patch for eggfindbar.c
Can anybody check the patch? I've got some problems with autogen... I've tried to use the same implementation as in epiphany ephy-find-toolbar.c, ie to use a toolbar instead of a mere hbox.
Hi Fabricio, thanks for working on this problem If you have any problems with autogen, just describe them, we'll try to help. About patch, I was thinking about full copy-paste of this toolbar code from epiphany sources. To do that we need: 1. Contact chpe if we'll move this code to libegg and rename ephy namespace 2. Do the transfer 3. Take exact code from libegg or epiphany and place it into cut-and-paste dir 4. Use it in evince.
I googled to find the purpose of libegg! But it would be a nice thing to add findbar's epiphany code to libegg, so that it can be used in evince in a suitable way. I will try to do my best! About autogen: I still have some troubles. Here's the end of log: [...] checking for TIFFReadRGBAImageOriented in -ltiff... yes configure: creating ./config.status config.status: error: cannot find input file: Makefile.in I suppose you'll need more infos to help me, just tell me what!
Libegg is a generic library of gtk widgets that are not stable/useful enough to include them into gtk directly. Some apps are using it though. It's located in gnome cvs: http://cvs.gnome.org/viewcvs/libegg/ About automake, it's probably better to attach full log, not just little end. Makefile.in is generated by automake. It looks like you had troubles running it, but they are reported earlier. Check lines around running automake-1.7 in the beginning.
Created attachment 66341 [details] [review] competing patch Too bad I also started working on this particular request yesterday :( Anyway I attach my patch, it is similar in spirit to Fabio, modifying eggfindbar.c to give it ephy look instead of using ephy-find-toolbar.c. Well here it is, and it works.
Sorry guys, that was my fault. There are more then 150 bugs about evince, and you decided to work on this particular one. Why is it so attractive? The same situation about second patch, I think it's much better to have completely identical shared code with epiphany. Even if code will be copy-pasted, it's much better than two different implementations. Btw, if you are searching for another bug, feel free to contact me.
Nicolay: Looks like marking bugs with gnome-love works. Fabricio: I'll let you work on it if you don't mind.
Hello! I noticed that in bug 167477, chpe and B. Clark are saying that evince and epiphany are using the same egg widgets, but I have seen no sign of EggFind! Are those comments too old and deprecated? Another point : I'm not sure to understand what you do want. Shall I try to add a eggfindbar.c to libegg and then we just have to copy this code to evince in the cut-n-paste directory? Frederic : I glance your patch and it seems to be much more complete than mine! but with your agreement, I'll try to carry on... About autogen, it was a mere dependency problem : debian unstable provides poppler 0.4.5 and still not 0.5.2. So I downloaded tarball from poppler site. I've just a last question : where can I specify that poppler libs are not in the usual place?
They are correct, but there was no EggFind that time. The problem is not in moving eggfindbar but in moving ephy code to libegg. For that you need to contact epiphany maintainer if they are agree with it and then suggest them a patch that will change namespace in epiphany code. Then we'll import code from libegg to evince. About installed poppler - export shell variable PKG_CONFIG_PATH=$(poppler_prefix)/lib/pkgconfig, say /home/user/local/lib/pkgconfig where poppler.pc is located. After that configure will find poppler.
(In reply to comment #13) > I noticed that in bug 167477, chpe and B. Clark are saying that evince and > epiphany are using the same egg widgets, but I have seen no sign of EggFind! > Are those comments too old and deprecated? Epiphany did use EggFindBar at one point during developement, but it was removed because I didn't like the code too much. (In reply to comment #14) > They are correct, but there was no EggFind that time. The problem is not in > moving eggfindbar but in moving ephy code to libegg. For that you need to > contact epiphany maintainer if they are agree with it and then suggest them a > patch that will change namespace in epiphany code. I'm ok with this, but it's probably not possible to just take ephy-find-toolbar.[ch] and s/ephy/egg/ since it's tied to our embedding layer... probably needs some modifications/refactoring. > Then we'll import code from > libegg to evince. I think code can only be in libegg when there's a clear target library, whose maintainer has agreed to that. What we *can* do is just use Egg prefix, but keep the master implementation in epiphany or evince themselves.
> I'm ok with this, but it's probably not possible to just take > ephy-find-toolbar.[ch] and s/ephy/egg/ since it's tied to our embedding > layer... probably needs some modifications/refactoring. That is the task that should be done first. > I think code can only be in libegg when there's a clear target library, whose > maintainer has agreed to that. What we *can* do is just use Egg prefix, but > keep the master implementation in epiphany or evince themselves. Libegg code is more appropriate for the code promotion, that's why I am asking to import findbar there :)
I've just read a discusion (http://mail.gnome.org/archives/usability/2005-February/msg00127.html) on find bar and usability. I would be nice to take all those ideas in account and propose a standard find-toolbar. I'm currently trying to merge epiphany and evince find codes in order to cleanly remove the embedding layer... Talking about libegg, it seems to me that it is very important that libegg is just a transient location before code integrate a clearly defined target library.
I would like this bug fixed for GNOME 2.16 but I believe the work to integrate every find toolbars in existence (at least Epiphany, Yelp, Evince and now Evolution) into libegg won't fit the timeframe. What about applying patch 66341 (can't tell for the other, it may be as valid) and keeping this bug open as a reminder for libegg integration ?
Ok, sorry for delay, I've modified patch a bit and committed. I hope I don't break anything with it. Although it would be nice to get common findbar, let's hope someone will handle this task on the next release cycle.