GNOME Bugzilla – Bug 167477
Find bar doesn't need to have a close button
Last modified: 2005-04-03 00:05:59 UTC
The Close button on the Find bar seems to be very out of place. No other GTK toolbar has ever had its own close button, let's reserve them for windows and tabs. Instead the Find toolbar extension of Epiphany is a nicer way to do it: simply hide it whenever focus is lost.
Heh, funny timing. This sounds good to me. Here's my usability message which relates to this: http://mail.gnome.org/archives/usability/2005-February/msg00134.html And the evince list message which releates to this: http://mail.gnome.org/archives/evince-list/2005-February/msg00018.html
Christian, how epiphany does this? Are you using the egg widget too? Should we sync code? /me never looked at the code
It looks like we're using the same egg widget as ephy find. http://cvs.gnome.org/viewcvs/epiphany-extensions/extensions/find/
Marco, yes, ephy find extension uses a slightly modified EggFindBar (I #ifdef'd the close button away :), and EphyFindBar builds on that to provide the close-on-focus-out behaviour. It does that by connecting to "set-focus" on the toplevel in show, and checking in the callback if the focus is in a descendent of the find bar; else it emits close on the find bar.
Should we integrate this directly in EggFindBar? It would be nice to have consistent behavior in apps using it...
Yes, I believe the best thing to do is keep sync'd up in EggFind. I think we came to agreement on everything in the usability thread that Christian started.
Created attachment 38944 [details] [review] port focus handling and removed close button from EphyFindBar
Committed, thanks.