After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336121 - Import Recent files code from libegg
Import Recent files code from libegg
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 327662
Blocks:
 
 
Reported: 2006-03-26 22:26 UTC by Emmanuele Bassi (:ebassi)
Modified: 2006-04-17 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Preliminary version of the import (287.21 KB, patch)
2006-03-26 22:29 UTC, Emmanuele Bassi (:ebassi)
needs-work Details | Review
long descriptions for the api doc (15.20 KB, patch)
2006-04-17 15:26 UTC, Emmanuele Bassi (:ebassi)
none Details | Review

Description Emmanuele Bassi (:ebassi) 2006-03-26 22:26:22 UTC
Tracker bug for importing the code living in libegg/recentchooser into gtk+, pending the import of the parser code (libegg/bookmarkfile) into glib.
Comment 1 Emmanuele Bassi (:ebassi) 2006-03-26 22:29:15 UTC
Created attachment 62074 [details] [review]
Preliminary version of the import

This is a patch against HEAD.

It includes all the GtkRecent* stuff, plus a couple of changes from the libegg code; a test suite similar to the FileChooser one; documentation; a migration guide, for people moving from the old EggRecent code.
Comment 2 Matthias Clasen 2006-03-28 19:48:20 UTC
Here are some small things I noticed in the included docs, not necessarily
merge blockers...

- missing short/long descriptions
- some functions are missing since tags 
- Maybe we should group the recent files classes
  into their on chapter, and add an introductory section like
  we have for the textview/treeview
- seems that including struct docs in headers doesn't quite work
  (generates bad output)
- in migration guide, should suppress links in examples
- I think the migration guide should have a concrete example
  old code vs. new code
Comment 3 Matthias Clasen 2006-03-28 19:54:45 UTC
some more things (already mentioned on irc)
-  gtk_recent_chooser_menu_init and gtk_recent_chooser_default_init need to initialize show_icons to TRUE
Comment 4 Matthias Clasen 2006-03-28 20:07:38 UTC
Another thing is adding aliasing, but I can handle that after the patch is merged.
Comment 5 Emmanuele Bassi (:ebassi) 2006-03-29 20:29:03 UTC
I've merged a fixed version of the patch above, along with the API for setting the screen singleton manager and the constructor property requested in 
bug #336208

> - missing short/long descriptions
> - some functions are missing since tags

Fixed before merge.

> - Maybe we should group the recent files classes
>   into their on chapter, and  add an introductory section like
>   we have for the textview/treeview

The introductory section is still missing, but the grouping inside the "Recently Used Documents" section is done. We can revert later, if we want to move the recent chooser widgets to the selector widgets section.

> - gtk_recent_chooser_menu_init and gtk_recent_chooser_default_init need to
>   initialize show_icons to TRUE
> - adding aliasing

Fixed before merging.

Still pending:

> - seems that including struct docs in headers doesn't quite work
>   (generates bad output)
> - in migration guide, should suppress links in examples
> - I think the migration guide should have a concrete example
>   old code vs. new code
> - Add a GtkRecentChooserMenu to the appwindow demo in gtk-demo

For these I'll attach a patch to this bug.
Comment 6 Federico Mena Quintero 2006-03-29 22:42:37 UTC
This is fantastic!  Thanks for merging this, Emmanuele!
Comment 7 Emmanuele Bassi (:ebassi) 2006-04-17 15:26:03 UTC
Created attachment 63718 [details] [review]
long descriptions for the api doc

long descriptions for the gtkrecent* template files
Comment 8 Matthias Clasen 2006-04-17 15:35:24 UTC
Small typo: shouldn should be should 

Otherwise, it looks fine to commit.
Comment 9 Matthias Clasen 2006-04-17 20:33:45 UTC
I'll close this now. Please open a new one for ui manager integration