After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327662 - Import BookmarkFile from libegg
Import BookmarkFile from libegg
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks: 336121
 
 
Reported: 2006-01-19 04:19 UTC by Emmanuele Bassi (:ebassi)
Modified: 2011-02-18 15:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glue against glib HEAD (4.04 KB, patch)
2006-01-19 04:20 UTC, Emmanuele Bassi (:ebassi) 		none Details | Review
gbookmarkfile.h (6.67 KB, text/plain)
2006-01-19 04:21 UTC, Emmanuele Bassi (:ebassi) 		  Details
gbookmarkfile.c (93.57 KB, text/plain)
2006-01-19 04:21 UTC, Emmanuele Bassi (:ebassi) 		  Details
gbookmarkfile.h (7.53 KB, text/plain)
2006-03-24 23:37 UTC, Emmanuele Bassi (:ebassi) 		  Details
gbookmarkfile.c (93.69 KB, text/plain)
2006-03-24 23:38 UTC, Emmanuele Bassi (:ebassi) 		  Details
glue against GLib HEAD (10.66 KB, patch)
2006-03-24 23:38 UTC, Emmanuele Bassi (:ebassi) 		none Details | Review
test suite (5.60 KB, text/plain)
2006-03-24 23:40 UTC, Emmanuele Bassi (:ebassi) 		  Details
GBookmarkFile doc template (8.75 KB, text/plain)
2006-03-24 23:41 UTC, Emmanuele Bassi (:ebassi) 		  Details

Description Emmanuele Bassi (:ebassi) 2006-01-19 04:19:22 UTC 
Tracker bug for importing the desktop bookmark parser object, needed by the RecentManager.

Also, the BookmarkFile could be used for the FileChooser bookmarks.
Comment 1 Emmanuele Bassi (:ebassi) 2006-01-19 04:20:32 UTC 
Created attachment 57627 [details] [review]
glue against glib HEAD

Glue needed for the GBookmarkFile stuff to compile against GLib HEAD
Comment 2 Emmanuele Bassi (:ebassi) 2006-01-19 04:21:23 UTC 
Created attachment 57628 [details]
gbookmarkfile.h
Comment 3 Emmanuele Bassi (:ebassi) 2006-01-19 04:21:50 UTC 
Created attachment 57629 [details]
gbookmarkfile.c
Comment 4 Emmanuele Bassi (:ebassi) 2006-03-24 23:36:37 UTC 
New version, including the remarks done during the review. there also is a test suite and the template for the reference documentation.
Comment 5 Emmanuele Bassi (:ebassi) 2006-03-24 23:37:46 UTC 
Created attachment 61948 [details]
gbookmarkfile.h

the GBookmarkFile API
Comment 6 Emmanuele Bassi (:ebassi) 2006-03-24 23:38:15 UTC 
Created attachment 61949 [details]
gbookmarkfile.c

the GBookmarkFile implementation
Comment 7 Emmanuele Bassi (:ebassi) 2006-03-24 23:38:57 UTC 
Created attachment 61950 [details] [review]
glue against GLib HEAD

glue for the build system
Comment 8 Emmanuele Bassi (:ebassi) 2006-03-24 23:40:09 UTC 
Created attachment 61951 [details]
test suite

test suite for GBookmarkFile.

there are also a bunch of invalid/valid files, like the ones we have in tests/markups that might be added.
Comment 9 Emmanuele Bassi (:ebassi) 2006-03-24 23:41:27 UTC 
Created attachment 61952 [details]
GBookmarkFile doc template

template for gtk-doc containing a description of GBookmarkFile and of the format.
Comment 10 Matthias Clasen 2006-03-25 15:27:16 UTC 
Emanuele, thanks for all that work. I'll try to review it by Monday...
Comment 11 Matthias Clasen 2006-03-27 15:35:20 UTC 
It looks all good to me. Can you commit it ? 
It would be great if you could add a tests/bookmarks subdirectory with some
valid and invalid examples, and add a little shell script like we have for 
the markup stuff.

Also, please add something like "The GBookmarkFile parser was added in GLib 
2.10." at the end of the long description.

Thanks again
Comment 12 Emmanuele Bassi (:ebassi) 2006-03-27 18:34:30 UTC 
committed.