After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333503 - re-import after unchecking 'Copy files to the Photos folder'
re-import after unchecking 'Copy files to the Photos folder'
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
SVN
Other Linux
: Normal normal
: 0.7.2
Assigned To: F-spot maintainers
F-spot maintainers
: 338567 522374 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-05 16:27 UTC by Luis Villa
Modified: 2010-08-02 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Luis Villa 2006-03-05 16:27:31 UTC
In 0.1.10, when I select a directory to import pictures from and then uncheck 'import into ~/Photos', it reimports them into the dialog again. Very irritating when you're importing a couple hundred photos.
Comment 1 Luis Villa 2006-03-05 21:37:48 UTC
Tangentially, if you uncheck this while photos are being loaded, f-spot hangs.
Comment 2 srn 2006-03-08 00:17:52 UTC
I think this is related to bug 314702 and bug 318519. It's probably a dupe of one of them (I feel like we should just have one bug called "Import dialog slightly insane". ;) )
Comment 3 Bengt Thuree 2006-03-08 12:41:21 UTC
Marking itas duplicate of bug 318519


*** This bug has been marked as a duplicate of 318519 ***
Comment 4 Luis Villa 2006-03-08 12:49:05 UTC
This is not by any stretch of the imagination a duplicate. It is very poor form to lump tons of related bugs together in one bugzilla entry; it makes it harder for the developer to track and fix them all and much easier to overlook specific parts of the problem.
Comment 5 srn 2006-03-09 00:52:12 UTC
The underlying problem looks to be that photos are processed as soon as the directory to import from is chosen; that processing can involve copying the files to ~/Photos, as well as creating and displaying the thumbnails.

Is that an accurate summary?
Comment 6 Larry Ewing 2006-03-09 03:31:18 UTC
yeah, but the import code could be smarter and keep a reference to both the original position and the copied position and be smarter about changes.
Comment 7 srn 2006-03-09 03:36:58 UTC
It shouldn't be copying the files until the dialog is closed, surely. As it stands it looks like f-spot is just showing a preview when in fact it's copying and importing the files.

The way it is imposes a strange order on filling in the dialog - if you want to not copy the files you first have to click on the "Copy files" checkbox, then select the location to import from...
Comment 8 Larry Ewing 2006-03-09 03:42:45 UTC
no the copying is fine, there is code to delete the files if the option changes, (there is a small bug there too but that is easy t fix).  Copying is the slowest part of the process, so doing it while the user is interacting is important.  The dialog is also supposed to allow you chose to not import images which is potentially time consuming so the idea is to do as much processing behind the scenes as we can while that is happening.  The dialog is just incomplete and buggy so instead of being seamless it is painful.
Comment 9 srn 2006-03-09 21:24:34 UTC
Copying the files takes forever, and if it's only happening because I forgot to uncheck the "copy files" button, it's a complete waste of time...

I guess the problem is that in my workflow importing into my home directory from the camera is the wrong thing (I have a big networked, backed-up RAIDed volume for the photos), so I always copy from the camera to another volume, then import into f-stop. I guess it'd be okay for people who just keep their little photo collection in their home directories.

Having a default setting for the "copy files" option would make me happy...
Comment 10 Gabriel Burt 2006-04-30 13:23:25 UTC
*** Bug 338567 has been marked as a duplicate of this bug. ***
Comment 11 Bengt Thuree 2007-11-29 17:13:23 UTC
Confirming that this still happens in latest SVN.

Larry mentioned that we need to copy the photos directly in the background, since this will take a long time. 
Also, we have also had problems with people importing photos from the camera, and not realizing that they only linked not copied the photos, so they deleted the original photos.

A default option hidden in GConf should be possible though. 
Should be easy to implement as a patch, but can not be done until the re-design of the import is done. Should be marked gnome-love at that time.
Comments anyone?
Comment 12 Tim Retout 2008-04-22 13:22:51 UTC
*** Bug 522374 has been marked as a duplicate of this bug. ***
Comment 13 Mike Wallick 2010-07-27 13:55:51 UTC
I don't think this is an issue any longer in the 0.7.x branch.

I do not see this behavior in 0.7.1. I do see this behavior in 0.6.1.5 (which came preinstalled with Ubuntu Lucid) as well as 0.6.2 (the latest 0.6.x version built from source).

Plus this bug hasn't been touched in over two years.
Comment 14 Ruben Vermeersch 2010-08-02 13:45:38 UTC
Yeah, this is fixed with the new import. Thanks for pointing out.