After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331761 - Icons for GNOME Power manager which blend in better with GNOME
Icons for GNOME Power manager which blend in better with GNOME
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: general
SVN TRUNK
Other Linux
: Normal normal
: ---
Assigned To: Jakub Steiner
GNOME Power Manager Maintainer(s)
: 331710 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-02-19 11:32 UTC by Jaap A. Haitsma
Modified: 2006-04-18 11:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
scalable icons (104.92 KB, application/x-compressed-tar)
2006-04-17 12:12 UTC, Andreas Nilsson
Details

Description Jaap A. Haitsma 2006-02-19 11:32:54 UTC
Jakub,

Could you come up with icons which blend in better with the GNOME icon theme. The current icons are designed for BlueCurve. Also icons for Tango would be nice ofcourse.

Thanks

Jaap
Comment 1 Jaap A. Haitsma 2006-02-19 11:34:50 UTC
Jakub,

The icons of GNOME power manager are in 
http://cvs.gnome.org/viewcvs/gnome-power-manager/data/icons/

Comment 2 Jaap A. Haitsma 2006-02-19 11:36:03 UTC
*** Bug 331710 has been marked as a duplicate of this bug. ***
Comment 3 Luca Cavalli 2006-02-19 17:15:33 UTC
Tango style is not yet officially adopted by GNOME (isn't it?), so old GNOME style should be far better. Anyway Jakub already did some work in this direction [1], but I can't find under which license are those icons released.

[1] - http://jimmac.musichall.cz/i.php?i=PowerManager
Comment 4 Richard Hughes 2006-02-19 17:22:50 UTC
They look really good! But we would need 24x24 versions for the tray more than the svg versions.
Comment 5 Jaap A. Haitsma 2006-02-19 19:59:18 UTC
Ideally I think we would want
svg
22x22
16x16

and then depending on the size of the panel choose the right icon size and scale it to the appropriate size
Comment 6 Jakub Steiner 2006-02-20 11:46:02 UTC
16x16 and 22x22 versions are coming soonish. They will be released under whatever license gnome-power-manager comes (GPL?).

As for the old Gnome style, I am not extending the life of a zombie. Tango guidelines have been written for the style to be compatible with the legacy GNOME look. Tango is the future.
Comment 7 Richard Hughes 2006-02-20 11:51:31 UTC
GPL indeed. Thanks for your work Jakub.
Comment 8 Richard Hughes 2006-02-20 16:18:46 UTC
Okay, hypothetically, we now have two icon sets, effectivly bluecurve and tango.

Do the tango icons belong upstream, that-is in the tango icon spec (and tango theme package) or should g-p-m be shipping them by default? The bluecurve icons could then go into the bluecurve icon set.

Or g-p-m could install the tango icons *and* the bluecurve icons into thier respective directories, and then we can add/remove icons as we please.

Or should g-p-m stick to what it's doing now, sticking them in /usr/share/gnome-power-manager/icons (probably not...)

I'm not sure what the upstream protocol is with icons. Help!

Thanks.
Comment 9 Jakub Steiner 2006-02-21 16:45:10 UTC
I'm done with the bitmaps now. The icons can be found here:

http://jimmac.musichall.cz/stuff/powermanager-tango.tar.bz2

You can generate 24x24 version out of the 22x22 by adding a 1px padding with imagemagick:

`convert -bordercolor Transparent -border 1x1 in.png out.png`
Comment 10 Jakub Steiner 2006-02-21 16:51:19 UTC
As for the Tango vs Bluecurve question - Tango is not a Novell icon branding. Tango project has been founded to create a common visual style for free software gui applications to use. It's not a GNOME thing, it's more generic. I don't believe icons are a meant to brand a project, to make it look pretty and unique. Icons are there to help figure out functionality better than a plain text label. That's why I think applications should have their icons adhere to the tango style. 

Distributors that want to brand their product by changing icon style may do so thanks to theming. 
Comment 11 Richard Hughes 2006-02-21 17:32:49 UTC
Jakub. One comment.... WOW!

With regard to the tango discussion, I appreciate what it's trying to do, but my question was one a little more pratical. Do I install the icons to /usr/share/icons/Bluecurve/* and /usr/share/icons/hicolor/*, right?

Also, in a related note, could you do a couple of extra icons please, as we now can show a different icon if the UPS is discharging or charging, the same as the primary battery. I think all it needs is the charging "flash" overlayed on the image somewhere.
If you do one SVG, I don't mind copying the placement and doing the others for you.

Also, as I'm moving the entire CVS tree, can you think of better icon names?

Currently they are gnome-power-{device}-{state}-{level}-of-{maxlevel}

but this does not fit in with the icon naming spec at all :-)

Should they stay prefixed with gnome-power-* (as they are not part of the spec) or be renamed to something more generic, so that say the KDE guys could use a particular icon. Thanks again.

Richard.
Comment 12 Richard Hughes 2006-02-21 17:51:11 UTC
After installing these icon in my theme, I've noticed that some icons, such as the 22x22 px version of gnome-power-ac-4-of-8, it's not as clear as it should be, for the charge of the battery. Can we make the blue, bluer, and/or the gap between the blue and the sides of the battery smaller (if you know what I mean) so that there are more pixels representing the charge. I think with so few pixels (22) we need to make the information carrying bit (the blue pixels) somewhat easier to "read".

But then I'm no graphic designer, in fact I can't even draw!
Comment 13 Jakub Steiner 2006-02-21 19:48:15 UTC
* I'm not sure the problem of not being able to tell state 6 from state 7 is in the icon. It's the number of steps. Do you really need 8 states for a panel icon? 
* The bitmaps are not directly rendered from the SVG. The SVG is only a starting point. The bitmaps need bitmap love [*]
* As far as where the icons go, I believe apps should install to hicolor. Rodney, please correct me if I'm wrong here.
* Rodney is the mastermind behind the cool naming spec so he'd probably help with a generic naming for these too.
* The last one relates to the outcome of the previous note, but what naming should I use for the UPS-charging icons?

[*] http://jimmac.musichall.cz/weblog.php/Artwork/ScalableIcons.php, http://jimmac.musichall.cz/demos/gimp/bitmaps.avi
Comment 14 Richard Hughes 2006-02-21 20:00:44 UTC
>I'm not sure the problem of not being able to tell state 6 from state 7 is in
>the icon. It's the number of steps. Do you really need 8 states for a panel
>icon? 

Yes, or people get upset and start talking about generating pixmaps with the *exact* charge percentage of the battery... :-)

If Rodney tells us new names, I will rename the current icons in CVS.

Currently we have:

gnome-dev-acadapter.png
gnome-power-ac-0-of-8.png
gnome-power-ac-1-of-8.png
gnome-power-ac-2-of-8.png
gnome-power-ac-3-of-8.png
gnome-power-ac-4-of-8.png
gnome-power-ac-5-of-8.png
gnome-power-ac-6-of-8.png
gnome-power-ac-7-of-8.png
gnome-power-ac-8-of-8.png
gnome-power-ac-charged.png
gnome-power-bat-0-of-8.png
gnome-power-bat-1-of-8.png
gnome-power-bat-2-of-8.png
gnome-power-bat-3-of-8.png
gnome-power-bat-4-of-8.png
gnome-power-bat-5-of-8.png
gnome-power-bat-6-of-8.png
gnome-power-bat-7-of-8.png
gnome-power-bat-8-of-8.png
gnome-power-keyboard.png
gnome-power-mouse.png
gnome-power-ups-charged.png
gnome-power-ups-charging-0-of-8.png
gnome-power-ups-charging-1-of-8.png
gnome-power-ups-charging-2-of-8.png
gnome-power-ups-charging-3-of-8.png
gnome-power-ups-charging-4-of-8.png
gnome-power-ups-charging-5-of-8.png
gnome-power-ups-charging-6-of-8.png
gnome-power-ups-charging-7-of-8.png
gnome-power-ups-charging-8-of-8.png
gnome-power-ups-discharging-0-of-8.png
gnome-power-ups-discharging-1-of-8.png
gnome-power-ups-discharging-2-of-8.png
gnome-power-ups-discharging-3-of-8.png
gnome-power-ups-discharging-4-of-8.png
gnome-power-ups-discharging-5-of-8.png
gnome-power-ups-discharging-6-of-8.png
gnome-power-ups-discharging-7-of-8.png
gnome-power-ups-discharging-8-of-8.png

Thanks, Richard.
Comment 15 Rodney Dawes 2006-02-21 20:08:35 UTC
Eek. So yeah, there are WAY TOO MANY icons in gnome-power-manager. Do we really need 8+ states for battery, charging battery, and UPS? I say plus, as there is also "charged" in the case where you have 100% batter, and the ac is plugged in.

I think at most, there should be 4 states total, for stateful icons. Let me think about the power management stuff a bit more, and I'll get back to you. The only icons that should be installed to hicolor, are the app icons themselves. Battery state and such, are status icons, and we should not be promoting conflict with other applications, by installing stateful icons. This is one of the primary needs for the Naming Spec. Perhaps "charging" should just be an emblem that gets overlaid on top of the other icons. This way, we don't have to draw the same icon N times. It's more a matter of how much information we really need to show to the user, than how much we can show them. Can you give me a list of all that we /can/ show, and I'll try to come up with a naming scheme and idea of what we /should/ show? Thanks.
Comment 16 Richard Hughes 2006-02-21 20:21:54 UTC
>Eek. So yeah, there are WAY TOO MANY icons in gnome-power-manager. Do we really
>need 8+ states for battery, charging battery, and UPS?

Yes, else people complain that the tooltip is not representative of the charge.

Maybe 8 could be reduced to 5, but I can't see it getting any smaller than that.

>...there is also "charged" in the case where you have 100% battery,
>and the ac is plugged in.

Yes, required in the current implimentation. A battery at 99% and charging is different from a battery not charging at 100% completely charged.

>Perhaps "charging" should just be an emblem that gets overlaid on top of the
>other icons.

No easy to do, as some icons (such as UPS) might want the charging symbol in a different place to others (such as primary battery).
Might be worth looking into tho, altho I'm not sure how I can achieve this in the current implimentation.

>Can you give me a list of all that we /can/ show

Is the list above the one you need?

Thanks for your help guys, it's appreciated.
Comment 17 David Zeuthen (not reading bugmail) 2006-02-21 20:32:28 UTC
In response to comment 15:
> So yeah, there are WAY TOO MANY icons in gnome-power-manager. Do we really
> need 8+ states for battery, charging battery, and UPS? 

Why on earth is this a problem?

> Perhaps "charging" should just
> be an emblem that gets overlaid on top of the other icons. 

By doing this you're effectively restraining themes. You're restraining what creative ideas artists may have. Case in point; for UPS discharging the new Bluecurve icons all show orange shades (rather than green as for the laptop battery) because we want to convey it's a pretty serious matter that the UPS is running on it's batteries.

> This way, we don't
> have to draw the same icon N times. 

This is a really bad excuse.

> It's more a matter of how much information
> we really need to show to the user, than how much we can show them.

Sure, but please respect that a lot of people have already been thinking a lot about exactly what icons to choose.

I'm opposed to changing what icons g-p-m use.
Comment 18 David Zeuthen (not reading bugmail) 2006-02-21 20:34:32 UTC
> I'm opposed to changing what icons g-p-m use.

To clarify.. I'm opposed to changing the naming convention.. I'm not opposed to theming.. and.. at some point.. I'm not opposed to the idea that g-p-m could ship the GNOME and/or Tango icons in the tarball. Then Red Hat could ship the Bluecurve icons in redhat-artwork.
Comment 19 Jaap A. Haitsma 2006-02-21 20:35:05 UTC
Very nice icons. :-)

Two comments 

1. The current "*0-of-8*" icons are not really usable. You can't really use it for an empty battery because then the laptop won't even boot ;-) Also it's not really usable for a very very low battery charge because it doesn't contain anything red so the user won't be alarmed. I think we can just delete it, right?

2. I think it's better we have only one "red icon" which indicates that the battery is low and that the user should take some action. Maybe 2-of-8 can be orange or yellow?
Comment 20 Andy Somerville 2006-02-21 20:39:36 UTC
I don't know if its heresy to suggest, but might there be a way of creating the "fill" programmatically? perhaps with alpha masks etc? Im sure there could be lots of arguments against this, but perhaps it is workable.

Just a thought.
Comment 21 David Zeuthen (not reading bugmail) 2006-02-21 21:05:49 UTC
Comment 19:
> The current "*0-of-8*" icons are not really usable. 

Sure they are, icon 0 is used when you have 0-12.5% (or is it 0-6.25%) left.

Comment 20:
> I don't know if its heresy to suggest, but might there be a way of creating the
> "fill" programmatically? perhaps with alpha masks etc? Im sure there could be
> lots of arguments against this, but perhaps it is workable.

Already discussed on the g-p-m mailing list and rejected. It's very much against the idea of theming.

Comment 22 Jaap A. Haitsma 2006-02-21 21:17:21 UTC
(In reply to comment #21)
> Comment 19:
> > The current "*0-of-8*" icons are not really usable. 
> 
> Sure they are, icon 0 is used when you have 0-12.5% (or is it 0-6.25%) left.
> 
It's 0-6.25% currently. The percentage is divided by 12.5 and then rounded. 

Why I don't like is because there is nothing alarming (no red) about 0-of-8. It could even mean a fully loaded battery if you wouldn't know that that is displayed in a blue color. Furthermore 0-of-8 is completely empty so the only mental link people can make is that the battery is empty
Comment 23 David Zeuthen (not reading bugmail) 2006-02-21 21:22:23 UTC
> Why I don't like is because there is nothing alarming (no red) about 0-of-8. It
> could even mean a fully loaded battery if you wouldn't know that that is
> displayed in a blue color. Furthermore 0-of-8 is completely empty so the only
> mental link people can make is that the battery is empty

Right. I kinda agree with you. But in this case I think they get a notification or modal dialog.. perhaps that notification or modal dialog should be TOPMOST and have the property that it can't be dismissed until the user restores AC power..
Comment 24 Jakub Steiner 2006-02-21 21:28:59 UTC
David, if you think saving an artists valuable time and lower the possibility of an error by allowing him to create an emblem instead of X versions of the same thing, I don't think you're restratining him. Restratining an artist in creating a nother theme of this is by requiring to theme a 50+ icons for a simple thing as a tiny status icon that really is there only to tell me if my fricken battery is still alright or if I need to recharge my notebook. If for some odd reason I would be interested if my batterry is 40% full or 38% I can check the tooltip.
Comment 25 Andy Somerville 2006-02-21 21:29:31 UTC
(In reply to comment #17)
> In response to comment 15:
> > So yeah, there are WAY TOO MANY icons in gnome-power-manager. Do we really
> > need 8+ states for battery, charging battery, and UPS? 
> 
> Why on earth is this a problem?

I dont see a problem with having so many icons either. One small thing I could see argued is inconvenience of the themers having to make more icons (and therefore be discouraged from doing so).

Might we even go further and simply check the file names and allow x-of-n and adjust accordingly? Is there a good reason for a constraint here? This would allow theme designers to have their conveinece[cake] and extensiblity[eat it] too.

Also perhaps UPS and other extra icons could be used if present or ignored if not.

Again just a new-comer's thoughs. Apologies if any of this has been discussed on the list.
Comment 26 Jakub Steiner 2006-02-21 21:33:23 UTC
I also agree on either dropping 0-8 or if you insist on having it there for 0-12.5  I'd make it what 1-8 is now and make 2-8 dark blue.
Comment 27 David Zeuthen (not reading bugmail) 2006-02-21 21:38:27 UTC
Comment 24:
> David, if you think saving an artists valuable time and lower the possibility
> of an error by allowing him to create an emblem instead of X versions of the
> same thing, I don't think you're restratining him. Restratining an artist in
> creating a nother theme of this is by requiring to theme a 50+ icons for a
> simple thing as a tiny status icon that really is there only to tell me if my
> fricken battery is still alright or if I need to recharge my notebook. If for
> some odd reason I would be interested if my batterry is 40% full or 38% I can
> check the tooltip.

I kinda take offense at this because a lot of my valuable time have been invested in doing all the infrastructure for gnome-power-manager. In case you didn't know, g-p-m does a whole lot more than just displaying how much juice in your "fricken battery" [sic] - it's much more than what the battery applet in GNOME used to do.

Jakub, You cannot seriously mean that it's a problem to apply the emblems to the icons yourself?!? Please..

Comment 28 Richard Hughes 2006-02-21 21:42:08 UTC
>I also agree on either dropping 0-8 or if you insist on having it there for
>0-12.5  I'd make it what 1-8 is now and make 2-8 dark blue.

I'm not sure it matters. It's up to the theme designer for that particular theme. One theme might have a solid green dot for 100% battery, fading to a red dot for 0% battery -- we shouldn't apply policy to the theme.

The only thing we need to decide on is the icon names (so we can make it themeable) and how many intermediate states we need. The rest can be left the the artists.

Richard.
Comment 29 Jaap A. Haitsma 2006-02-21 22:23:52 UTC
The current division of intervals is a bit weird, because we try to fit 9 icons into a 100% scale

So currently

Range            icon
0 - 6.25%        0-of-8
6.25% - 18.75%   1 of 8
...
81.25% - 93.75%  7 of 8
93.75% - 100%    8 of 8

It's more logical to have steps which are always 12.5%
So if we remove 0-of-8 we get

0 - 12.5%     1 of 8
12.5 - 25%    2 of 8
....
87.5 - 100%   8 of 8

We'd probably then want to subtract one of the icon name to make the calculation of which icon to use really trivial.

Visually my preference then would be
1 of 8    red  (battery low. Indication that I need to inspect how many minutes are still left)
2 of 8    orange or yellow (indication that my battery are almost getting low)


So Jakub only needs change one icon and people loving detailed info keep in the icon keep that info.
We only need to change the following function

static gint
get_icon_index_from_percent (gint percent)
{
	const gint NUM_INDEX = 8;
	gint	   index;

	index = ((percent + NUM_INDEX / 2) * NUM_INDEX ) / 100;
	if (index < 0) {
		return 0;
	} else if (index > NUM_INDEX) {
		return NUM_INDEX;
	}
	return index;
}

to

static gint
get_icon_index_from_percent (gint percent)
{
	const gint NUM_INDEX = 8;
	gint	   index;

	index = percent * NUM_INDEX / 100;
	if (index < 0) {
		return 0;
	} else if (index >= NUM_INDEX) {
		return NUM_INDEX - 1;
	}
	return index;
}

Sounds like a plan??
Comment 30 Richard Hughes 2006-02-21 22:34:03 UTC
What about these as icon names:

ac-adapter
keyboard-power-low
mouse-power-low
battery-charged
battery-charging-10
battery-charging-30
battery-charging-50
battery-charging-70
battery-charging-90
battery-discharging-10
battery-discharging-30
battery-discharging-50
battery-discharging-70
battery-discharging-90
ups-charged
ups-charging-10
ups-charging-30
ups-charging-50
ups-charging-70
ups-charging-90
ups-discharging-10
ups-discharging-30
ups-discharging-50
ups-discharging-70
ups-discharging-90

A compromise between the massive number of icons we have now, and providing enough information in the tray.

Jaap, what about the numbers I propose:

00-20 = 10
20-40 = 30
40-60 = 50
60-80 = 70
80-99 = 90
100   = charged
Comment 31 David Zeuthen (not reading bugmail) 2006-02-21 22:52:17 UTC
Comment 30:
> 00-20 = 10
> 20-40 = 30
> 40-60 = 50
> 60-80 = 70
> 80-99 = 90
> 100   = charged

Makes a lot of sense for me to go from 9 -> 5 icons.. I guess my main grief with Jakub was charging vs. not charging using an emblem...
Comment 32 Jaap A. Haitsma 2006-02-21 23:07:15 UTC
In the low area you would like some more precision. With 20% battery power I for example still have more then 1 hour of battery time.
So you would like to have a seperate icon for for example 0 to 10%


Comment 33 Andy Somerville 2006-02-21 23:16:19 UTC
I dont mean to be redundant, but why not check the file names of those which include numbers and adjust accordingly? 

With either scheme:
"battery-charging-x-of-n" - calculate based on maybe "x"/"n"
or 
"battery-charging-Xpct"  - round scheme which uses whichever icons exist

Its both extensible and convenient. It resolves both concerns.
Comment 34 Richard Hughes 2006-02-21 23:20:54 UTC
>I dont mean to be redundant, but why not check the file names of those which
>include numbers and adjust accordingly? 

As it makes an otherwise simple bit of code very complicated, requiring lots of stat's to get the theme total. I want a fixed number of icons to keep the code simple.
Comment 35 Richard Hughes 2006-02-21 23:30:45 UTC
>In the low area you would like some more precision. With 20% battery power I
>for example still have more then 1 hour of battery time.
>So you would like to have a seperate icon for for example 0 to 10%

So what about...

ups-charged
ups-charging-000
ups-charging-020
ups-charging-040
ups-charging-060
ups-charging-080
ups-charging-100

00-10  = 000
10-30  = 020
30-50  = 040
50-70  = 060
70-90  = 080
90-100 = 100

And then "charged" when not charging.

This gives us double resolution at both ends of the scale, but not 9 icons.
Comment 36 Jakub Steiner 2006-02-21 23:40:37 UTC
Alrighty, back to the drawing board. 22x22 versions following the new naming scheme are at http://jimmac.musichall.cz/i.php?i=PowerManager. 16x16 and scalables to follow.
Comment 37 Jakub Steiner 2006-02-21 23:47:27 UTC
One thing I noticed - does battery-charged need to lose the plug even when plugged in? or do you want to have another state for non-charging battery with a plugged ac?
Comment 38 Richard Hughes 2006-02-21 23:49:24 UTC
battery-charged = laptop is being powered on AC, but the battery is 100% charged, and no longer charging. I think that's specific enough.

Jakub, are you using the 000, 020, 040 scheme? I think that works best.
Comment 39 Jakub Steiner 2006-02-21 23:53:06 UTC
Richard, yes I just redid it to follow the 000,020... scheme. I'll fix the -100 state to be more full then, if a full battery without ac connected is not a state we want to have.
Comment 40 Rodney Dawes 2006-02-22 04:41:46 UTC
GAH! Please stop rushing everything. Do you want my input or not? If not, then you can just keep going along with installing junk in $(datadir)/gnome-power-manager and we can go on our merry way and not have the icons be themable. If you do, then please slow down, and stop trying to rush everything. Seriously. Numbers generally suck. There are way too many icons here. I can't even easily reply to this amount of traffic. It's a lot of work just reading all this text and trying to address all of the comments. And no, I do not like the proposed names. They aren't really solving the problems. They're just basically stripping off the gnome-power- prefix. If you rush and just do whatever, then we're going to be having this exact same discussion again later. And I'd rather avoid having the same conversation multiple times. It's rather boring, and means we aren't solving the problems.

So, please. Just wait until I get some time to actually look at the problem more deeply. We're not going to fix this for 2.14 anyway. It's not possible. We're shipping an older gnome-icon-theme with old names. This should be targetted for 2.16. If you have at least better icons than I remember seeing, just ship them in 2.14 with the current names, and installed in the gnome-power-manager datadir. Last I looked, it will be a bit of work to do the right thing for using icon themes anyway, as g-p-m was loading its icons as new stock icons through GtkStock. Hopefully I will be able to look at this soon, but please just be patient.
Comment 41 Richard Hughes 2006-02-22 10:54:56 UTC
>Numbers generally suck

Why?

>We're not going to fix this for 2.14 anyway

Yes, I know. I wanted to fix this in CVS soon so I can ship bluecurve icons *and* tango icons.

>and installed in the gnome-power-manager datadir

What's wrong if I start putting the icons (whatever the name) in hicolor? The determined few (that I get emails from) want to theme g-p-m in thier own wacky way, and short of doing stuff to /usr/share/gnome-power-manager/*.png they cannot.

Richard.
Comment 42 Rodney Dawes 2006-02-22 16:41:50 UTC
(In reply to comment #41)
> >Numbers generally suck
> Why?

Because they do. The % value does not tell the user how much time they have
left. And basing which icon to use on the % value, means you end up having
inconsistent icon usages across different laptops, because 10% for one user
might mean 1 minute, while 10% for another, might mean 40 minutes. So, "red"
battery might not really be all that urgent. This all needs to be based on
the amount of time left, rather than the % of battery left.

> >We're not going to fix this for 2.14 anyway
> Yes, I know. I wanted to fix this in CVS soon so I can ship bluecurve icons
> *and* tango icons.

Ship them *how*? If we're not fixing it for 2.14, how exactly is this going to
be shipped?

> >and installed in the gnome-power-manager datadir
> 
> What's wrong if I start putting the icons (whatever the name) in hicolor? The
> determined few (that I get emails from) want to theme g-p-m in thier own wacky
> way, and short of doing stuff to /usr/share/gnome-power-manager/*.png they
> cannot.

Well, you can't install both sets of icons, into the same theme. What does
"their own wacky way" really mean here? Please provide examples.
Comment 43 Richard Hughes 2006-02-22 17:19:11 UTC
>Because they do. The % value does not tell the user how much time they have
>left. And basing which icon to use on the % value, means you end up having
>inconsistent icon usages across different laptops, because 10% for one user
>might mean 1 minute, while 10% for another, might mean 40 minutes.

Please see the other bugzillas on this subject, like #326743 for example. It's not always quite as easy as you might think to get a time remaining.

Plus I think people want to see an icon thats proportional to the amount of *charge* of the class of the specific device, rather than a different icon for the amount of time remaining -- that's quite abstract.

In your scenario, imagine you did a kernel compile for a few minutes, your battery discharge rate would increase (proportional to CPU load), and your time remaining until empty would also go down substantially. The kernel compile finishes, the rate decreases, and the time remaining doubles. The icon would go "up" -- which is not exactly easy to explain to somebody.

I'm sure we don't want to do this per-time.

>Ship them *how*? If we're not fixing it for 2.14, how exactly is this
> going to be shipped?

Shipped in the g-p-m tarball. Maybe shipped was the wrong word, apologies.

>Well, you can't install both sets of icons, into the same theme.

Ovbiously, but we can install into other theme directories right? For things like LowContrast and the HighContrast ally stuff.

>What does "their own wacky way" really mean here? Please provide examples.

How about #331710

Richard.
Comment 44 Jaap A. Haitsma 2006-02-22 18:56:47 UTC
I agree with Richard that the battery should not display time remaining because of the variation on time remaining depending on the load and also with Rodney that the remaining time for a fixed percentage is very different on different machines.

So what about the following:

We have 6 (or whatever number we find appropriate) icons with a blue filling which represent the different percentages of charge.

Furthermore we have of the lowest percentage also one with a red filling. 

Currently if at some moment there is 30 minutes remaining gpm shows a notification that the battery is low. In the code we make sure it's only displayed once because of the fact that the remaining time can go up again if the load on the machine changes.

What about if we then at that moment change the icon to the one with the red filling?
I think it solves both Richard's and Rodney's point

So we would have for example

battery-charge-low  (like battery-charge-10 but red)
battery-charge-10  for 0 to 10%
battery-charge-20  for 10 to 30%
battery-charge-40  for 30 to 50%
battery-charge-60  for 50 to 70%
battery-charge-80  for 70 to 95%
battery-charge-full for 95 to 100% 


Different icon themes
---------------------
Shipping different icon themes inside gpm sounds like a bad idea to me. We should just ship the default icon theme (tango I guess) and let theme authors add their icons to their icon theme package. That's easiest for both us coders and the theme designers.

Comment 45 Richard Hughes 2006-02-24 17:45:24 UTC
>battery-charge-low  (like battery-charge-10 but red)
>battery-charge-10  for 0 to 10%

I don't see the benefit for having two icons for effectivly one state...
Most batteries < 3-4% are going to be "low" so the icon won't display for long...

>battery-charge-80  for 70 to 95%
>battery-charge-full for 95 to 100% 

Why not just:

battery-charge-80  for 70 to 90%
battery-charge-100 for 90 to 100% 
?
Richard.
Comment 46 Richard Hughes 2006-02-25 21:12:19 UTC
Jaap:

For the moment stick to:

ups-charged
ups-charging-000
ups-charging-020
ups-charging-040
ups-charging-060
ups-charging-080
ups-charging-100

for now. I want to release g-p-m with more sane names than we have now, so I can add the extra UPS icons. The possible rename, or addition of additional "warning icons" can be done at a later time.

Richard.
Comment 47 Richard Hughes 2006-03-06 09:27:36 UTC
Jakub, can you attach what you've got please, and I'll work moving them towards CVS. Thanks.
Comment 48 Jakub Steiner 2006-03-06 12:12:56 UTC
Richard, http://jimmac.musichall.cz/stuff/PM-icons.tar.bz2
Comment 49 Richard Hughes 2006-03-06 12:21:56 UTC
Cheers Jakub. I notice there are some scalable icons missing, is that by design or accident? I don't think we'll be using the svg's in g-p-m for a little while, but we may someday. Thanks.
Comment 50 Jakub Steiner 2006-03-06 12:34:21 UTC
Neither by design nor accident. They are simply not done yet. But I'll make them eventually.
Comment 51 Richard Hughes 2006-03-06 12:44:53 UTC
Aye, gotcha, thanks.
Comment 52 Richard Hughes 2006-03-06 14:59:53 UTC
Ohh, the 60% icons for each device are missing too. Thanks Jakub.
Comment 53 Jakub Steiner 2006-03-06 17:14:47 UTC
Oopsie. The 060 bitmaps should now be contained in the archive mentioned above.
Comment 54 Corey Burger 2006-03-06 23:56:55 UTC
I have a small concern about only producing Tango icons. If GNOME ships g-p-m in 2.16 but does not switch to the actual Tango icons, there is a small problem.
Comment 55 Rodney Dawes 2006-03-07 03:06:41 UTC
Tango is not an icon theme. There is a Tango Icon Theme, but Tango is much more than that. And if you'll notice in CVS HEAD of gnome-icon-theme, that many of the icons already are following the Tango Style Guidelines, and that they look much better than their predecessors.
Comment 56 Corey Burger 2006-03-07 07:22:43 UTC
As long as we are using the style guide and the naming scheme without the palette that is fine.
Comment 57 Rodney Dawes 2006-04-03 15:07:16 UTC
GNOME is switching to the Tango style in 2.16. Several of the icons in gnome-icon-theme CVS are already following the naming scheme, and using the style guidelines and palette. I think you are a bit confused as to how all this really works.
Comment 58 Jaap A. Haitsma 2006-04-17 11:00:27 UTC
Richard,

The gnome-icon-theme and also several apps are switching to Tango already. What about applying the Tango icons to GPM?
Comment 59 Andreas Nilsson 2006-04-17 12:12:44 UTC
Created attachment 63694 [details]
scalable icons

Put together the rest of the icons in the scalable size, as some were missing from Jakubs archive.
Comment 60 Richard Hughes 2006-04-17 16:59:27 UTC
Thanks Andreas. I'll work on adding the tango icons today.
Comment 61 Jakub Steiner 2006-04-17 17:15:21 UTC
Thanks Andreas. I didn't quite like the changing transparency of the "fluid" thought so I made it the same as on the bitmaps. I also renamed the files to us ethe gpm- prefix. The tarball is on the same location -
 
http://jimmac.musichall.cz/stuff/PM-icons.tar.bz2
Comment 62 Richard Hughes 2006-04-17 17:57:07 UTC
New icons look much better, thanks Jakub.
Comment 63 Richard Hughes 2006-04-17 19:14:33 UTC
2006-04-17  Richard Hughes  <richard@hughsie.com>
 * data/icons/*/*: Switch to using the Tango style. Thanks go to Jakub Steiner for a very nice icon set. Fixes #331761.
 * src/gpm-tray-icon.h: use gpm-battery-charged as our application icon.

If there are any problems then please open a new bug, with the specific problem.

Thanks,

Richard.
Comment 64 Jakub Steiner 2006-04-18 11:16:33 UTC
My pleasure. Thanks for liking them :)