After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330851 - installs icon in the wrong place.
installs icon in the wrong place.
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Mikael Hallendal
Mikael Hallendal
Depends on:
Blocks:
 
 
Reported: 2006-02-12 01:38 UTC by Behdad Esfahbod
Modified: 2006-02-18 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Behdad Esfahbod 2006-02-12 01:38:58 UTC 
Currently devhelp installs it's icon in DATADIR/pixmaps.  It should install it in DATADIR/icons/hicolor/48x48/apps such that it's themeable.
Comment 1 Richard Hult 2006-02-17 22:43:22 UTC 
Good catch. We also need to add some gtk-update-icon-cache fu to the build. Also see http://bugzilla.gnome.org/show_bug.cgi?id=144859 for a new nicer icon.
Comment 2 Behdad Esfahbod 2006-02-17 23:46:28 UTC 
What I found from doing this in gucharmap and dasher is that the application then simply needs to call gtk_window_set_default_icon_name ("devhelp").  I'll check about the gtk-update-icon-cache fu and commit.
Comment 3 Richard Hult 2006-02-17 23:54:34 UTC 
Great, thanks!
Comment 4 Behdad Esfahbod 2006-02-18 10:34:49 UTC 
2006-02-18  Behdad Esfahbod  <behdad@gnome.org>

        * src/dh-main.c (main): Pass gettextized string to
        g_set_application_name, as per glib docs recommendation.

        * src/dh-main.c (main): Set default icon name to devhelp.

        * src/dh-window.c (dh_window_new): Set window icon name
        to devhelp (and no icon file tweaking at all.)

        * ui/Makefile.am: Install PNG and SVG icons in the themeable
        locations.  Call gtk-update-icon-cache.  Distribute ui/COPYING.
        Fixes bug #330851.

        * ui/devhelp.svg, ui/devhelp.png: Shiny new single red book icon
        from Marcus Leyman. Fixes bug #144859.

        * ui/COPYING: Copying infor for the new icon.