After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314774 - [patch] xrdb called needlessly multiple times
[patch] xrdb called needlessly multiple times
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
2.22.x
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-29 14:51 UTC by Erwann Chenede
Modified: 2008-11-01 00:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.32 KB, patch)
2005-08-29 14:52 UTC, Erwann Chenede 		committed Details | Review

Description Erwann Chenede 2005-08-29 14:51:57 UTC 
Please describe the problem:
From John's bug http://blogs.sun.com/roller/page/jmr/20050826
we can see that xrdb is called multiple times when gnome-settings-daemon 
is started.

Steps to reproduce:
this happens at every login


Actual results:


Expected results:


Does this happen every time?
yes

Other information:
It seems that the style_set_cb callback, which ultimately spawn the xrdb
command, is called multiple times.
This happens because the style_set_cb callback is connected to the GtkWidget
signal "style-set"
which receive multiple "style-set" signals (8 or 9) initially for the same theme.

One solution to avoid these multiple calls would be to monitor the gtk theme
Xsettings property
as gtk does (via "notify::gtk-theme-name")
Comment 1 Erwann Chenede 2005-08-29 14:52:50 UTC 
Created attachment 51514 [details] [review]
patch

a patch which fixes the multiple call problem using Xsettings instead of the
"style-set" signal.
Comment 2 Christian Kirbach 2005-09-01 21:28:58 UTC 
confirming because of the patch.
Comment 3 Rodrigo Moya 2005-10-15 21:59:31 UTC 
Patch is committed, although we are still running xrdb -merge in 3 different
places. Something needs to be done to just be run once (or none?)
Comment 4 Behdad Esfahbod 2008-11-01 00:06:51 UTC 
Two of those 3 are with -nocpp, which is really really fast.  The other will be disabled by default when bug 557807 is fixed.  Closing bug.