After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557807 - disable xrdb plugin by default
disable xrdb plugin by default
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2008-10-24 20:08 UTC by William Jon McCann
Modified: 2008-11-03 21:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
One line patch (925 bytes, patch)
2008-11-03 19:02 UTC, Behdad Esfahbod
committed Details | Review

Description William Jon McCann 2008-10-24 20:08:37 UTC
The xrdb plugin does some seriously ancient legacy stuff.  Since it reads off the disk it slows down startup.

We should probably (at least) disable this by default.
Comment 1 Behdad Esfahbod 2008-10-24 20:11:08 UTC
Worse, xrdb indirectly runs gcc!  May even make sense splitting the downstream packages as to not drag gcc in by g-s-d RPM.
Comment 2 Jens Granseuer 2008-10-25 11:07:40 UTC
(In reply to comment #0)
> We should probably (at least) disable this by default.

Go ahead.
Comment 3 Michael Meeks 2008-10-29 14:24:41 UTC
The Moblin guys seemed to suggest that simply caching the pre-processed gcc output gets a big chunk of the win, with ~no functionality loss [ says the lazy-ass old-time emacs user that uses Xresources to clobber the colors ;-].

And of course, we install a load of .ad files in data/ to get theming right for old apps it seems.

If we did a fairly simple programmatic substitution of our own, well-controlled 'data/*.ad' files, then presumably we could add: -nocpp to the xrdb command-line for in the case where there is no user-installed ~/.Xresources or ~/.Xdefaults - which should give a nice win; or - perhaps even mandate that our .ad files have a simple, non-pre-processed syntax, and implement xrdb ourselves for them [ xrdb.c is (I assume) at root only a lot of XChangeProperty calls, and only 1300 LOC itself ].

HTH.
Comment 4 Jens Granseuer 2008-10-29 17:41:59 UTC
I guess the main question behind all this is how long do we want to lug legacy compatibility code along? There are other places than this (e.g. the cursor font stuff Behdad pointed to). In this case, instead of sinking a lot of time into fine-tuning and micro-optimizations I'd rather advocate disabling the plugin by default and seeing if anyone complains. If you're the only one (which doesn't seem that unlikely to me), well, run xrdb using the autostart mechanism or something.
Comment 5 Behdad Esfahbod 2008-10-30 08:07:26 UTC
I wonder, is there a UI to enable/disable g-s-d plugins?  That feature should be added to the GUI tool we have for the session.
Comment 6 Behdad Esfahbod 2008-11-01 00:07:25 UTC
I almost wrote a mini-cpp using GScanner, but gave up.  I agree that GNOME shouldn't by default care about other toolkit's theming.
Comment 7 Behdad Esfahbod 2008-11-03 19:02:23 UTC
Created attachment 121895 [details] [review]
One line patch
Comment 8 Behdad Esfahbod 2008-11-03 21:11:53 UTC
2008-11-03  Behdad Esfahbod  <behdad@gnome.org>

        * data/gnome-settings-daemon.schemas.in: Disable xrdb plugin by
        default (#bug #557807)