After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312920 - gtkmenutoolbutton needs to deactivate menu when it's set insensitive
gtkmenutoolbutton needs to deactivate menu when it's set insensitive
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkToolbar
2.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-08-08 18:23 UTC by Christian Persch
Modified: 2005-08-08 18:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (5.72 KB, patch)
2005-08-08 18:24 UTC, Christian Persch 		none Details | Review

Description Christian Persch 2005-08-08 18:23:49 UTC 
This code was previously in button_state_changed_cb, but that's currently #if
0'd out, and to be removed, as per bug 310589 comment 3. Attached patch does
that, and fixes the problem. Ok to commit?
Comment 1 Christian Persch 2005-08-08 18:24:23 UTC 
Created attachment 50407 [details] [review]
proposed patch
Comment 2 Soren Sandmann Pedersen 2005-08-08 18:27:54 UTC 
Looks good, if you have tested that it works when the menubutton becomes
insensitive while the arrow button is pressed (ie., the arrow doesn't stay down
or anything like that).
Comment 3 Christian Persch 2005-08-08 18:32:01 UTC 
Yes, tests/testtoolbar tests for this, works fine. Deactivating the menu sets
the arrow button inactive, from menu_deactivate_cb().
Comment 4 Christian Persch 2005-08-08 18:34:56 UTC 
2005-08-08  Christian Persch  <chpe@cvs.gnome.org>

        * gtk/gtkmenutoolbutton.c: (gtk_menu_tool_button_state_changed),
        (gtk_menu_tool_button_class_init), (popup_menu_under_arrow),
        (gtk_menu_tool_button_init):

        Deactivate the menu when the button becomes insensitive, and remove
        dead code. Fixes bug #312920.