After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310589 - gtkmenutoolbutton improvements
gtkmenutoolbutton improvements
Status: RESOLVED NOTABUG
Product: gtk+
Classification: Platform
Component: Widget: GtkToolbar
2.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-07-16 14:19 UTC by Christian Persch
Modified: 2011-02-04 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (7.70 KB, patch)
2005-07-16 14:21 UTC, Christian Persch 		none Details | Review

Description Christian Persch 2005-07-16 14:19:49 UTC 
There are a couple of problems with gtkmenutoolbutton:
- the menu isn't aligned to the button but to the arrow; a regression from
Epiphany's own widget
- the button isn't shown depressed when the menu is shown
- in rev 1.9 of gtkmenutoolbutton.c, ssp broke prelighting

The attached patch fixes all these, and fixes the code to use ->priv instead of
GET_PRIVATE macro everywhere (except in _init of course).
Comment 1 Christian Persch 2005-07-16 14:21:38 UTC 
Created attachment 49285 [details] [review]
proposed patch

Also sets focus-on-click to FALSE on the arrow button.
Comment 2 Matthias Clasen 2005-07-20 18:50:57 UTC 
Soeren, can you look at this patch ?
Comment 3 Soren Sandmann Pedersen 2005-08-01 15:16:43 UTC 
I think the menu-alignment makes sense, provided that a menu which is narrower
than the two buttons combined gets its right edge aligned with the right edge of
the arrow-button (in LTR). Feel free to open a new bug about that.

Also using button->priv is fine. Go ahead and commit that if you'd like.

I don't like the other changes though. After discussing them with Seth, I am
going to reject those. The two buttons represent different actions, so their
depressed-ness and prelighted-ness should be independent.

Closing NOTABUG.
Comment 4 Christian Persch 2005-08-08 18:14:48 UTC 
I've committed the ->priv part; going to open separte bugs for the remaining things.