After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312246 - FR does not read all pending output
FR does not read all pending output
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2005-08-01 15:09 UTC by Claudio Bley
Modified: 2005-08-02 16:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Read output from commands until EOF (3.28 KB, patch)
2005-08-01 15:18 UTC, Claudio Bley
none Details | Review

Description Claudio Bley 2005-08-01 15:09:49 UTC
As I already mentioned in http://bugzilla.gnome.org/show_bug.cgi?id=157940 a
long time ago, there is a problem sometimes such that there's no output from the
command line in the error message dialog.

The problem is that the command may not in every case end its output with a
newline before EOF. For example rar does that when testing of an archive fails.

Additionally, the "Command Line Output" scrolled window inside the "Error"
dialog looks a bit ugly because of its shadow type.
Comment 1 Claudio Bley 2005-08-01 15:18:24 UTC
Created attachment 50071 [details] [review]
Read output from commands until EOF

+ Process the output of commands line by line, but read until the end of output
when EOF on the file descriptor is encountered.

+ Changed the shadow type of the scrolled window inside the Error dialog to
GTK_SHADOW_ETCHED_IN.
Comment 2 Paolo Bacchilega 2005-08-02 16:35:12 UTC
patch applied, thank you.