After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 157940 - rar password and testing support, file name processing
rar password and testing support, file name processing
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2004-11-11 12:03 UTC by Claudio Bley
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for rar password and testing support; fix for file name processing (4.29 KB, patch)
2004-11-11 12:09 UTC, Claudio Bley
none Details | Review

Description Claudio Bley 2004-11-11 12:03:17 UTC
file-roller just didn't include rar password support and the testing of archives
up until now. But it easily can (patch attached) although it isn't obvious from
the rar documentation that you can pass rar a password via the -p switch when
extracting or testing an archive.

The caveats are: 

1) if both, the headers and the data of an rar archive are encrypted, even the
listing of the archive fails. 

2) if the password is wrong, a dialog is shown, but it doesn't contain any
output from the command line.


Also, I just changed the file name processing for rar archives. If listing an
rar archive the file name is on a line by its own, but the first character of
that line is an indicator which should be ignored whereas the file name is on
the rest of the line (including any white spaces at the end). If the indicator
character is an asterisk it means the file is encrypted.

I tested it with rar 3.30 and 2.80; and unrar 3.40.
Comment 1 Claudio Bley 2004-11-11 12:09:34 UTC
Created attachment 33673 [details] [review]
patch for rar password and testing support; fix for file name processing
Comment 2 Paolo Bacchilega 2004-11-11 21:36:13 UTC
Patch applied.  
Feel free to close the bug if you think your code is solid enough ;)
Comment 3 Claudio Bley 2004-11-25 17:00:30 UTC
Well, I dare to think it is solid enough. :) I'm using it for quite some time
without any problems now (except the aforementioned restrictions--I'll probably
look into the second one if I have the time).