GNOME Bugzilla – Bug 312095
Wrong icon for network:///
Last modified: 2005-08-29 09:22:01 UTC
Version details: nautilus 2.11.90 Distribution/Version: Ubuntu Breezy + Garnome Nautilus uses a plain folder icon for the network:/// URI instead of the network icon (other URIs like computer:///, burn:/// and trash:/// use their special icons, too). This affects both pathbar and bookmarks.
Thanks for pointing this out! nautilus_icon_factory_get_icon_for_file lacks special-case code for this. I'd like to get this fixed once the patch from bug 167107 is committed, since the latter is quiet huge compared to this tiny code addition.
Created attachment 49994 [details] [review] Proposed prelimitary patch I'm not sure whether this will still work after applying the patch from bug 167107, but this is the route to go :).
Just rebuild with all three patches (nautilus-private, the 16px patch and this one) applied. Builds fine and seems to work... But something I noticed before and is still true now: the special icons are not always used in the places bar, i think only after the URI has been visited! For example, if you 'killall nautilus' and have computer:///, network:///, burn:/// in the places bar, they show up as normal folders, clicking on them or typing the uri in the location bar changes the icon.
Michael: I can reproduce this and will investigate it later - it is unrelated to this problem, though. Feel free to open a new bug report :).
The other bug is now filed as #312134 now btw
Created attachment 50032 [details] [review] Proposed patch Thanks. I've just realized that I forgot smb:/// and that a combined patch against this one and bug 312134 is a good idea.
Just gave it a shot, again using the patch together with the ones from #167107, seems to be fine. Only thing I noticed, dunno if this is intended: smb:// displays the network icon, navigating even further, like smb://workgroup or just smb://host again displays the plain folder icon... shouldn't those use the network icon, too? And what about the sftp:// protocol? Wasn't there some "network filesystem" icon (folder with BNC T connector or something like that) for this kind of stuff (would fit for smb, too and I suppose nfs is in the same state as sftp, only displaying a folder)?
Michael: Thanks for your productive input. I'm sure we can do better in some areas, but we still can investigate this later. Imho the "BNC T connector" should only be used for volumes and shares, not their subfolders.
I've submitted the attached patch to the nautilus mailing list [1] for review. [1] http://mail.gnome.org/archives/nautilus-list/2005-August/msg00062.html
Any news regarding this and bug 312134?
A similar patch was committed, closing.