GNOME Bugzilla – Bug 167107
sidebar tree should use 16x16 icons
Last modified: 2005-11-22 17:31:49 UTC
Right now, the sidebar in nautilus uses scaled-down icons of folders, that look blurry. For consistency with gtk+ fileselector (see bug #165770), the sidebar should use the 16x16 (GTK_ICON_SIZE_MENU) versions of the same icons.
Created attachment 37359 [details] screenshot showing the inconsistency Here you can see the gtk+ fileselector (left) with 16x16 icons and the nautilus sidebar (right) with scaled down blurry icons.
While I'm at it, the sidebar history should do the same thing :)
Yes, you are totally right. I've spent some time investigating the nautilus icon factory and I think we should offer a function for getting GtkIconSize'd sizes.
Created attachment 46764 [details] [review] libnautilus-private patch (against HEAD). * cleans up nautilus_icon_factory API a bit * offers new functions for getting pixbufs for GtkIconSize'd icons.
Created attachment 46765 [details] [review] src/ patch (against HEAD). * ports src/ to new nautilus-icon-factory API * uses GtkIconSize'd items for menus (looks better) and sidebar (looks odd) (I think the fact that emblems show up as big as icons in tree views is a bug)
By "tree views" in comment 5 I mean the tree and list view.
Created attachment 46766 [details] Image showing off changes Do you like this size? I think it's a bit tiny actually.
This bug also affects the new "places" sidebar. Please take a look at this shot : http://www.gnome.org/~vnoel/screenshots/nautilus-new-browser.png Notice how the two "home" icons are different : the one in the path bar is a 16x16 icon (correct, crisp), the one in the "places" sidebar is downsized and blurry. Christian : the icons in attachment 46766 [details] don't look the right size... (ie they don't look like the folder icons in the gtk file selector)
Vincent: But they seem to match in physical size. I think the crippled look is due to the fact that I still used an old icon theme wich had no shrinked version for folder icons.
Created attachment 49835 [details] [review] src/ patch #2 (against HEAD) Updated against recent code changes and added sidebar code. It looks way more slick than those fuzzy ill-sized icons, really.
Created attachment 49836 [details] [review] src/ patch #3 (against HEAD) Last patch contained unrelated bits.
Hey Christian, I tried to apply your patch in attachment 49836 [details] [review]. It applies cleanly, but : * some unrelated bits are still there (the gnome-vfs improvement for Luis' bug) (thanks for this, by the way) * compilation breaks because you use nautilus_icon_factory_get_pixbuf_from_name_with_stock_size which is not defined anywhere in the nautilus tree (I grepped for it, and it's only present in your patch) Thanks !
Created attachment 49837 [details] [review] src/ patch #4 (against HEAD) > some unrelated bits are still there Yeah, thanks. I've just removed them. > compilation breaks because you use nautilus_icon_factory_get_pixbuf_from_name_with_stock_size which is not defined Don't forget to apply the libnautilus-private patch as well.
I knew I had forgot something :-)
We're UI frozen, this won't be included until 2.14.
Milsetoning to 2.14.
Mass changing Nautilus version for bugs that have GNOME 2.13 version info.
Removing BLOCKED_BY_FREEZE keyword.
Committed attachment 46764 [details] [review] and attachment 49837 [details] [review]. Closing.
*** Bug 320124 has been marked as a duplicate of this bug. ***
*** Bug 320965 has been marked as a duplicate of this bug. ***
*** Bug 319275 has been marked as a duplicate of this bug. ***
*** Bug 322147 has been marked as a duplicate of this bug. ***