After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167107 - sidebar tree should use 16x16 icons
sidebar tree should use 16x16 icons
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Sidebar Panel: Tree
2.13.x
Other All
: High normal
: 2.14.x
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 319275 320124 320965 322147 (view as bug list)
Depends on:
Blocks: 309698 311394 312095
 
 
Reported: 2005-02-11 17:50 UTC by Vincent Noel
Modified: 2005-11-22 17:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
screenshot showing the inconsistency (23.34 KB, image/png)
2005-02-11 17:52 UTC, Vincent Noel
  Details
libnautilus-private patch (against HEAD). (15.37 KB, patch)
2005-05-22 20:41 UTC, Christian Neumair
committed Details | Review
src/ patch (against HEAD). (11.07 KB, patch)
2005-05-22 20:43 UTC, Christian Neumair
none Details | Review
Image showing off changes (28.05 KB, image/png)
2005-05-22 20:47 UTC, Christian Neumair
  Details
src/ patch #2 (against HEAD) (14.65 KB, patch)
2005-07-27 12:38 UTC, Christian Neumair
none Details | Review
src/ patch #3 (against HEAD) (13.65 KB, patch)
2005-07-27 13:12 UTC, Christian Neumair
none Details | Review
src/ patch #4 (against HEAD) (12.52 KB, patch)
2005-07-27 13:35 UTC, Christian Neumair
committed Details | Review

Description Vincent Noel 2005-02-11 17:50:27 UTC
Right now, the sidebar in nautilus uses scaled-down icons of folders, that look
blurry.

For consistency with gtk+ fileselector (see bug #165770), the sidebar should use
the 16x16 (GTK_ICON_SIZE_MENU) versions of the same icons.
Comment 1 Vincent Noel 2005-02-11 17:52:23 UTC
Created attachment 37359 [details]
screenshot showing the inconsistency

Here you can see the gtk+ fileselector (left) with 16x16 icons and the nautilus
sidebar (right) with scaled down blurry icons.
Comment 2 Vincent Noel 2005-02-11 17:54:17 UTC
While I'm at it, the sidebar history should do the same thing :)
Comment 3 Christian Neumair 2005-05-22 17:42:44 UTC
Yes, you are totally right. I've spent some time investigating the nautilus icon
factory and I think we should offer a function for getting GtkIconSize'd sizes.
Comment 4 Christian Neumair 2005-05-22 20:41:33 UTC
Created attachment 46764 [details] [review]
libnautilus-private patch (against HEAD).

* cleans up nautilus_icon_factory API a bit
* offers new functions for getting pixbufs for GtkIconSize'd icons.
Comment 5 Christian Neumair 2005-05-22 20:43:51 UTC
Created attachment 46765 [details] [review]
src/ patch (against HEAD).

* ports src/ to new nautilus-icon-factory API
* uses GtkIconSize'd items for menus (looks better) and sidebar (looks odd)

(I think the fact that emblems show up as big as icons in tree views is a bug)
Comment 6 Christian Neumair 2005-05-22 20:44:27 UTC
By "tree views" in comment 5 I mean the tree and list view.
Comment 7 Christian Neumair 2005-05-22 20:47:48 UTC
Created attachment 46766 [details]
Image showing off changes

Do you like this size? I think it's a bit tiny actually.
Comment 8 Vincent Noel 2005-07-08 14:24:39 UTC
This bug also affects the new "places" sidebar.
Please take a look at this shot :
http://www.gnome.org/~vnoel/screenshots/nautilus-new-browser.png

Notice how the two "home" icons are different : the one in the path bar is a
16x16 icon (correct, crisp), the one in the "places" sidebar is downsized and
blurry.

Christian : the icons in attachment 46766 [details] don't look the right size... (ie they
don't look like the folder icons in the gtk file selector)
Comment 9 Christian Neumair 2005-07-26 23:13:13 UTC
Vincent: But they seem to match in physical size. I think the crippled look is
due to the fact that I still used an old icon theme wich had no shrinked version
for folder icons.
Comment 10 Christian Neumair 2005-07-27 12:38:08 UTC
Created attachment 49835 [details] [review]
src/ patch #2 (against HEAD)

Updated against recent code changes and added sidebar code. It looks way more
slick than those fuzzy ill-sized icons, really.
Comment 11 Christian Neumair 2005-07-27 13:12:33 UTC
Created attachment 49836 [details] [review]
src/ patch #3 (against HEAD)

Last patch contained unrelated bits.
Comment 12 Vincent Noel 2005-07-27 13:26:28 UTC
Hey Christian,
I tried to apply your patch in attachment 49836 [details] [review]. It applies cleanly, but :
* some unrelated bits are still there (the gnome-vfs improvement for Luis' bug)
(thanks for this, by the way)
* compilation breaks because you use
nautilus_icon_factory_get_pixbuf_from_name_with_stock_size which is not defined
anywhere in the nautilus tree (I grepped for it, and it's only present in your
patch)
Thanks !
Comment 13 Christian Neumair 2005-07-27 13:35:29 UTC
Created attachment 49837 [details] [review]
src/ patch #4 (against HEAD)

> some unrelated bits are still there

Yeah, thanks. I've just removed them.

> compilation breaks because you use
nautilus_icon_factory_get_pixbuf_from_name_with_stock_size which is not defined


Don't forget to apply the libnautilus-private patch as well.
Comment 14 Vincent Noel 2005-07-27 13:42:53 UTC
I knew I had forgot something :-)
Comment 15 Christian Neumair 2005-08-05 23:42:42 UTC
We're UI frozen, this won't be included until 2.14.
Comment 16 Christian Neumair 2005-09-22 12:02:49 UTC
Milsetoning to 2.14.
Comment 17 Christian Neumair 2005-10-03 12:27:12 UTC
Mass changing Nautilus version for bugs that have GNOME 2.13 version info.
Comment 18 Christian Neumair 2005-10-04 10:56:18 UTC
Removing BLOCKED_BY_FREEZE keyword.
Comment 19 Christian Neumair 2005-10-17 17:44:32 UTC
Committed attachment 46764 [details] [review] and attachment 49837 [details] [review]. Closing.
Comment 20 Christian Neumair 2005-10-28 21:25:57 UTC
*** Bug 320124 has been marked as a duplicate of this bug. ***
Comment 21 Christian Neumair 2005-11-08 16:19:42 UTC
*** Bug 320965 has been marked as a duplicate of this bug. ***
Comment 22 Christian Neumair 2005-11-11 08:45:46 UTC
*** Bug 319275 has been marked as a duplicate of this bug. ***
Comment 23 Christian Neumair 2005-11-22 17:31:49 UTC
*** Bug 322147 has been marked as a duplicate of this bug. ***