After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168388 - file roller shouldn't create an ARCHIVE_FILES folder if the archive only have one root folder
file roller shouldn't create an ARCHIVE_FILES folder if the archive only have...
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.9.x
Other Linux
: Normal enhancement
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
: 314143 324991 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-02-24 13:45 UTC by Julien Olivier
Modified: 2006-01-15 15:17 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12



Description Julien Olivier 2005-02-24 13:45:56 UTC
Version details: 2.9.91
Distribution/Version: ubuntu hoary

Currently, when you extract an archive, fileroller will create a new folder
called XXX_FILES where XXX is the name of the archive, and extract its content here.

If this behaviour is perfect in most cases, it's a bad behaviour in the case
where your archive's root consists of one and only one folder (it's the case for
most tgz archives of software source code). In this case, the extracted data
will lie in PATH/ARCHIVE_FILES/ROOT_FOLDER/.

I guess a better (but less consistent) behaviour could be not to create the
ARCHIVE_FILES folder in this very case.

Thanks.
Comment 1 Ernst Sjöstrand 2005-03-05 20:14:09 UTC
Patch to extract in current dir, not in _FILES dir.

--- /usr/src/file-roller-2.9.92/nautilus/nautilus-fileroller.c  2005-02-28
20:49:35.000000000 +0100
+++ nautilus-fileroller.c       2005-03-05 20:46:15.919394992 +0100
@@ -80,6 +80,7 @@
 {
        GList            *files;
        NautilusFileInfo *file;
+       GnomeVFSURI      *vfs_uri;
        char             *uri, *path, *dir_files;
        GString          *cmd;

@@ -88,7 +89,9 @@

        uri = nautilus_file_info_get_uri (file);
        path = gnome_vfs_get_local_path_from_uri (uri);
-       dir_files = g_strconcat (path, "_FILES", NULL);
+
+       vfs_uri = gnome_vfs_uri_new (uri);
+       dir_files = gnome_vfs_uri_extract_dirname (vfs_uri);

        cmd = g_string_new ("file-roller");
        g_string_append_printf (cmd,
@@ -99,6 +102,7 @@
        g_spawn_command_line_async (cmd->str, NULL);

        g_string_free (cmd, TRUE);
+       gnome_vfs_uri_unref (vfs_uri);
        g_free (dir_files);
        g_free (path);
        g_free (uri);
Comment 2 Jan de Groot 2005-03-19 14:48:40 UTC
Think this one is cleaner:
http://bugs.gnome.org/attachment.cgi?id=38884&action=view

This bug is a dupe of http://bugs.gnome.org/show_bug.cgi?id=167261
Comment 3 Sebastien Bacher 2005-04-10 13:36:21 UTC
Thanks for the bug report. This particular bug has already been reported into
our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of 167261 ***
Comment 4 Julien Olivier 2005-06-13 10:35:15 UTC

*** This bug has been marked as a duplicate of 167261 ***
Comment 5 Marius Scurtescu 2005-07-08 22:37:43 UTC
I am using file-roller 2.11.1 and this issue does not seem to be fixed properly.

The XXX_FILES folder is never created and it is supposed to be created if there
is no unique root folder in the archive.

This is a major issue, please revise.

Athor possible solutions:
- provide two menu options: "Extract Here..." and "Extract to ..."
- add a preference to control this behaviour

You could also group all file-roller menu items under one submenu.
Comment 6 Dennis Krul (dweazle) 2005-08-18 11:38:23 UTC
Reopening bug as further enhancements seem to be required.

I can't confirm it because I don't run 2.11.
Comment 7 Michaël Arnauts 2005-08-18 11:45:06 UTC
I run 2.11.* and it should indeed create folder if the archive doesn't have one.
Comment 8 Teppo Turtiainen 2005-08-22 21:06:46 UTC
*** Bug 314143 has been marked as a duplicate of this bug. ***
Comment 9 Paolo Bacchilega 2006-01-15 15:14:43 UTC
fixed in CVS.
Comment 10 Paolo Bacchilega 2006-01-15 15:17:23 UTC
*** Bug 324991 has been marked as a duplicate of this bug. ***