After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 130605 - If the screensaver is turned off the "lock the screen" action doesn't do anything
If the screensaver is turned off the "lock the screen" action doesn't do anyt...
Status: RESOLVED OBSOLETE
Product: gnome-panel
Classification: Other
Component: panel
git master
Other All
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 154596 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-01-05 20:22 UTC by Javier Amor García
Modified: 2020-11-06 20:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Proposed patch (1.06 KB, patch)
2004-07-25 17:52 UTC, Karthik Bharadwaj [Karthik BG]
needs-work Details | Review

Description Javier Amor García 2004-01-05 20:22:57 UTC
Description of Problem:
f the screensaver is turned off the "lock the
screen"æction doesn't do anything and don't give
any clue to the user about was is going on.

Steps to reproduce the problem:
1. Go to desktop prefrences->advanced->screensaver
and desactivate it
2. press actions->lock screen

Actual Results:
Nothing


Expected Results:
The screen should be locked with the screensaver


How often does this happen? 
Always

Additional Information:
If you look the founction panel_lock_screen in
panel-util.c you should see that the lock screen
function is provided calling the command
xscreensaver-command -lock. Well, if you
desactivate the screen saver and type the command
in the shell you wiill get: "xscreensaver-command:
screen blanking is currently disabled.
".  So it is a xscreensaver problem, and we must
do a workaround.

If we can't make the lock work at least we must
show a dialog telling the user what is going no.
If nothing happens, the user would believe that
the soft is broken; i believe it until, for
another reaso, turn the screensaver on.
Comment 1 Javier Amor García 2004-01-05 20:24:24 UTC
I forgot one last thing: it seems that the bug #85605 is related to
this one.
Comment 2 Karthik Bharadwaj [Karthik BG] 2004-07-25 17:52:05 UTC
Created attachment 29878 [details] [review]
Proposed patch
Comment 3 Kjartan Maraas 2004-09-01 22:10:25 UTC
Mark, did you have a look at this patch? It adds a string, but looks generally
ok to me at least.
Comment 4 Vincent Untz 2004-09-02 08:27:22 UTC
Does xscreensaver run on a specific screen or on all screens? By not using a
_on_screen function, we might add a bug...
Comment 5 manoj 2004-09-08 09:01:55 UTC
i will work on this defect.
Comment 6 Mark McLoughlin 2004-09-10 08:54:05 UTC
Comment on attachment 29878 [details] [review]
Proposed patch

In principle, I think its a good idea to pop up an error dialog in this case
although I think it would probably be more correct to de-sensitive the "Lock
Screen" menu item.

However, there are problems with this patch:

  - We need to be sure that launching xscreensaver-command -lock on any screen
will work

   - we shouldn't be spawning synchronously - this will cause the panel to lock
up if the command blocks
Comment 7 Vincent Untz 2004-10-15 19:54:27 UTC
*** Bug 154596 has been marked as a duplicate of this bug. ***
Comment 8 Peteris Krisjanis 2005-04-15 11:18:45 UTC
I suggest locking screen without xscreensaver made possible in the way like it
is done with Typing Break, because sometimes I really don't need screensaver,
just locking desktop. Just a idea, thought.
Comment 9 Vincent Untz 2005-08-18 09:54:19 UTC
Peteris: and how do you unlock the screen? This is why we need xscreensaver or
gnome-screensaver too, I guess :-)
Comment 10 Diego Escalante Urrelo (not reading bugmail) 2008-11-18 14:49:55 UTC
Is this still valid? IIRC gnome-screensaver can't be disabled.
Comment 11 André Klapper 2020-11-06 20:25:43 UTC
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all old bug reports in Bugzilla which have not seen updates for many years.

If you can still reproduce this issue in a currently supported version of GNOME (currently that would be 3.38), then please feel free to report it at https://gitlab.gnome.org/GNOME/gnome-panel/-/issues/

Thank you for reporting this issue and we are sorry it could not be fixed.