GNOME Bugzilla – Bug 99537
[ui-review] Menus and Toolbars capplet UI issues
Last modified: 2004-12-22 21:47:04 UTC
- s/Button Labels/Buttons labels - s/detached and moved around/detached - Order is 'Menus and Toolbars' in the title, the widgets are reversed in reality - Might be nice to have a preview pane for the menus to see the effect of instant apply - s/Text Below Icons/Text below icons - s/Text Beside Icons/Text beside icons - s/Icons Only/Icons only - s/Text Only/Text only
Created attachment 13000 [details] [review] A patch file...
I attached a patch to correct the following issues. 2002-12-15 Dennis Cranston <dennis_cranston@yahoo.com> * gnome-ui-properties.glade: Fixes for ui-review bug 99537. - s/Button Labels/Button labels - s/detached and moved around/detached - order is menus and toolbars in title, bug widgets are reversed - s/Text Below Icons/Text below icons - s/Text Beside Icons/Text beside icons - s/Icons Only/Icons only - s/Text Only/Text only
I can't remember if we discussed this in the ui-review or not, but "text beside" and "text below" really need to change, because if you drag your toolbars around (in nautilus say) so they're oriented vertically, the text is just wrong-- "text beside" puts the priority text below the icons, and "text below" puts the text beside the icons :) I'd say this is a bug in the wording rather than in the toolbar control, as placing the text the other way around for vertical toolbars would make them look even uglier than they already do :) So, IMHO the option menu really needs to say something more like: Button Labels: Text for all icons Text for important icons Icons only Text only
Dennis, thanks for the patch. I guess some more changes are required other than the ones addressed in the above patch (e.g., the changes above removes the outer frame (border-line) for Menus and Toolbar UI portions). Am attaching a patch as follows: Part-a: ------ - s/Button Labels/Button labels - s/detached and moved around/detached - Reverse Menus and Toolbar UI positioning Part-b: ------ - s/Icons Only/Icons only - s/Text Beside Icons/Text for important icons - s/Text Below Icons/Text for all icons - s/Text Only/Text only Part-b of the above orders the option menu from _Icons_ only to _Text_ only and also changes the label "Text Beside" and "Text Below" to "Text for important" and "Text for all" as Calum pointed out above.
Created attachment 14257 [details] [review] Patch as stated above.
Created attachment 14258 [details] Screen shot of the capplet with the above patch applied.
I guess this needs to use the GNOME 2.x frame style (bold text, no lines) if this is going to get back to development branch anytime soon... Personally I'd rather see one single preview area that showed both the menubar and toolbar, I've always thought this dialog looks rather cluttered considering it only has three options in it.
Can we please get these in early in the cycle for 2.4?
Are we going to use the latest patch here or is it going to be updated according to the comments?
Reopening so the patches don't get lost
Attached is replacement gnome-ui-properties.glade file that incorporates all the above changes (and a couple more tweaks). Tested against HEAD.
Created attachment 16396 [details] New glade file for Menus & Toolbars prefs dialog
Created attachment 16397 [details] Screenshot of same.
Note: ideally only the "New" and "Open" toolbar buttons in the preview area would be marked as having priority text, so that when you switch to "text for important icons", you only see text beside two of the three icons. I don't know how to do this though, and I don't have time to find out right at the moment :)
Created attachment 16758 [details] Another glade file for Menus & Toolbars prefs dialog with frames and widget padding modified per HIG.
Created attachment 16759 [details] Screen shot of above patch.
I attached another new glade file. It's the same as Calum's, but I have adjusted widget padding and converted the frames per the HIG.
Just FYI, "Text for all icons" really only makes sense in contrast to "Text for important icons".... Its better if the items are sensible enough that people can connect them to their current state w/o reading the other option menu items. "Text Below Icons" vs. "Text Beside Icons", while not as precise, may be more descriptive in terms of providing the most information on average.
Created attachment 18230 [details] [review] A patch file taking into account Seth's previous comments.
Created attachment 18231 [details] Screenshot of dialog.
It would be nice to get this change in before the freeze. Can I commit the above patch?
The patch has been applied to CVS. Resolving this bug report as fixed.
Dennis: The patch is fine, you made a slight mistake, though: You packed the toolbar preview widget into a GtkFrame which makes it look ugly since it means additional, non HIG-compliant spacing, plus you set it's shadow to IN. The attached patch fixes both issues by changing the shadow to OUT and packing the widget into a GtkAlignment. This should be the final touch for some months. regs, Chris
Created attachment 18413 [details] [review] I'm a patch. Click me! ;)
Thanks Chris! The only change I made to your patch was to remove '<requires lib="gnome"/>' from the glade file. 2003-07-18 Dennis Cranston <dennis_cranston at yahoo com> * gnome-ui-properties.c, gnome-ui-properties.glade: Apply patch from Christian - Manny Calavera - Neumair <chris@gnome-de.org> for ui-review bug # 99537.