GNOME Bugzilla – Bug 99536
[ui-review] Session manager UI issues
Last modified: 2004-12-22 21:47:04 UTC
The UI review team recommend the user interface specification at this URL: http://www242.pair.com/~nilsp/nils/sesh/sesh_hci_spec.html Additionally, to replace occurences of "Prompt" with "Ask".
Moving session properties bugs into the relevant component. Sorry for the e-mail spam (it's finished now): filter on "Andrew doing reassignment work" to get rid of it.
The URL cannot be accessed (error 403)...
Some of this is available from archive.org http://web.archive.org/web/20040217154509/http://www242.pair.com/~nilsp/nils/sesh/sesh_hci_spec.html Most things in this dialog are either broken beyond repair (needs a reworking of what we think sessions should do [see markmc's recent post]) or are just minor text cleanups. If someone just did the s/Prompt/Ask I'd be happy to close this bug and open a new one when we re-examine the session system.
Actually I could only find one occurrence of "Prompt" in the current gnome-session : Index: gnome-session/session-properties-capplet.c =================================================================== RCS file: /cvs/gnome/gnome-session/gnome-session/session-properties-capplet.c,v retrieving revision 1.33 diff -u -r1.33 session-properties-capplet.c --- gnome-session/session-properties-capplet.c 24 Aug 2004 12:45:00 -0000 1.33 +++ gnome-session/session-properties-capplet.c 1 Oct 2004 20:07:44 -0000 @@ -281,7 +281,7 @@ /* Logout prompt */ a = gtk_alignment_new (0.0, 0.5, 0.0, 0.0); gtk_box_pack_start (GTK_BOX (util_vbox), a, FALSE, FALSE, 0); - logout_prompt_button = gtk_check_button_new_with_mnemonic (_("_Prompt on logout")); + logout_prompt_button = gtk_check_button_new_with_mnemonic (_("_Ask on logout")); gtk_container_add (GTK_CONTAINER (a), logout_prompt_button); g_object_set_data (G_OBJECT (logout_prompt_button), "key", LOGOUT_PROMPT_KEY); gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (logout_prompt_button),
Yea, that's the only one I believe the bug was talking about. I guess it makes much more sense just to use full sentances and say 'replace "Prompt on logout" with "Ask on logout"' so we don't get complications between s/Prompt/Ask and s/Prompt/Ask/g or something. Sorry for any confusion.
Ok, so is this change ok to commit ?
Has this been committed?
Not yet. Is it ok to commit ?
Looks fine to me
Commited. I actually changed changed "_Prompt" to "As_k" as the "A" shortcut was already used in the dialog. Closing the bug.