GNOME Bugzilla – Bug 98980
cddb-track-editor doesn't produce valid cddb files
Last modified: 2004-12-22 21:47:04 UTC
Package: gnome-media Severity: major Version: 2.1.0 Synopsis: cddb-track-editor doesn't produce valid cddb files Bugzilla-Product: gnome-media Bugzilla-Component: Gnome-CD Description: Description of Problem: A newly created CD information file created by cddb-track-editor (started from gnome-cd) doesn't contain the mandatory fields EXTD and PLAYORDER, if they were left empty while editing. While some fields can be omitted (DGENRE and DYEAR) if the protocol level supported is <= 4, these have been present since version 1 of the DB format. Steps to reproduce the problem: 1. insert a CD that doesn't exist on the cddb server 2. open the track editor in gnome-cd, and omit to fill the EXTD (Disc comments) section 3. save the file Actual Results: The file saved in $HOME/.cddbslave lacks EXTD and PLAYORDER, but the DBFORMAT (from cddbp-1.4 software, downloadable from freedb.org) explicitly states that they must appear, but can be left empty. Expected Results: The same file with empty EXTD and PLAYORDER fields. How often does this happen? Highly reproducible, each time. Additional Information: ------- Bug moved to this database by unknown@bugzilla.gnome.org 2002-11-19 06:05 ------- The original reporter (mve@zurich.ibm.com) of this bug does not have an account here. Reassigning to the exporter, unknown@bugzilla.gnome.org. Reassigning to the default owner of the component, iain@ximian.com.
I think I found this bug. A missing fclose() in the parser. Attaching a patch.
Created attachment 17347 [details] [review] patch to fix the bug
Adding the PATCH keyword and re-assigning to the maint alias.
This has been fixed in Kjartan Marass' patch to fix bug 116804. That one involved various clean-ups, one was this fclose. I'm going to mark this as fixed until further notice.