After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 98779 - HIG parity: Defaults of GtkDialog style properties and separator
HIG parity: Defaults of GtkDialog style properties and separator
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 95773
Blocks: 98384
 
 
Reported: 2002-11-17 12:13 UTC by Gregory Merchan
Modified: 2011-02-04 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Gregory Merchan 2002-11-17 12:13:23 UTC
There is a mismatch between the HIG recommendations and GtkDialog defaults.
More than one bug has been filed against the HIG, and the HIG is likely
to change. I'm filing this to track the relevant changes in Gtk+.
Comment 1 Owen Taylor 2002-11-17 15:31:13 UTC
(Please be more explicit in these bugs.. I have a a hard time
figuring out when you mean by the above, though I'm pretty
sure it's a dup of bug 68938)

*** This bug has been marked as a duplicate of 68938 ***
Comment 2 Gregory Merchan 2002-11-17 20:44:32 UTC
This is only partially a duplicate of #68938. In addition to the
has_separator property of GtkDialog, there are three style properties
(content_area_border, button_spacing, action_area_border) for which
the HIG presently recommends values different from the defaults.

Property             Gtk+  HIG
--------------------------------
has_separator        TRUE  FALSE
content_area_border     2     12
button_spacing         10      6
action_area_border      5      0

In addition to this, the HIG would also have either 18px or 24px
of space above the action area buttons.

Increasing content_area_border without turning off the separator
yields an unpleasant appearance, and so should not be done.
Comment 3 Murray Cumming 2002-12-06 13:11:01 UTC
Reopening because this bug talks (eventually) about spacing and
borders, but that's not mentioned in bug 68938. 
Comment 4 Murray Cumming 2003-03-21 13:19:50 UTC
It would be nice to have a faily clear decision such as 
a) We will never change the default spacings.
b) We will do this later, but we don't know when.
Comment 5 Seth Nickell 2003-06-02 22:35:47 UTC
No comments from GTK devs?
Comment 6 Murray Cumming 2003-07-15 07:17:41 UTC
I currently think that our only and best option now is to hack glade
to use HIG defaults, or at least offer HIG defaults by name.
Comment 7 Murray Cumming 2003-07-24 13:53:56 UTC
So I have opened Glade bug 118186 instead.
Comment 8 Havoc Pennington 2003-07-27 23:57:54 UTC
Glade doesn't fix this bug, many GtkDialog aren't created from glade, 
especially trivial message dialogs.

Many GTK bugs take a long time to fix or even look at, there aren't
enough people working on it. Just relax.
Comment 9 Murray Cumming 2003-09-28 17:53:44 UTC
Havoc, I think that Owen has stated clearly (sorry, I can't find a
URL) that he does not wish to change GTK+ default property values
because it would affect existing applications.
Comment 10 Havoc Pennington 2003-09-29 16:10:13 UTC
If nothing else the bug should stay open for GTK 3, IMHO.

For MessageDialog at least I personally think it's OK to change the
default values; MessageDialog is less free-form than something like a
GtkFrame, it would probably not break any existing apps (and if it did
the breakage would be a cosmetic change to no separator).

Changing plain GtkDialog is perhaps more questionable.

People aren't going to use glade for GtkMessageDialog... why would
you, it's less code to just call gtk_message_dialog_new().
Comment 11 Owen Taylor 2004-03-13 22:04:34 UTC
GtkMessageDialog comes up, as far as I know, HIG compliant.

For GtkDialog, changing those style properties is not possible -
to verify this, try putting:

style "gtk-dialog-style" {
  GtkDialog::content-area-border = 12
  GtkDialog::button-spacing = 6
  GtkDialog::action-area-border = 0
}
                                                                     
          
class "GtkDialog" style "gtk-dialog-style"

into your ~/.gtkrc-2.0; you'll see that all current GTK+ applications
come up with entirely trashed padding/layout; I can't imagine
making that change even for GTK+-3.0.

I think this is basically a "Glade" level fix - most people
should be creating non-message-dialog boxes with glade anyways.

I suppose we could, add some API like 

 gtk_dialog_set_defaults (dialog, "GNOME");

But other than that, I don't see any way forward here. Changing
the defaults even of the style properties will make the
situation worse not better.