After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 97999 - gimp_image_scale() should indicate progress
gimp_image_scale() should indicate progress
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
1.x
Other Linux
: Normal enhancement
: 2.0
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2002-11-08 08:47 UTC by danfr527
Modified: 2004-02-09 00:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description danfr527 2002-11-08 08:47:25 UTC
Hi

I'm a bit confused about the way gimp is resizing images. When I use the
resize tool from the gimp main window, I get a progress bar telling me how
things going forward. But when i use the command resize image from the menu
I don't get that report at all. Also the whole app. seems to get locked and
I can't do anything. It would be nice if the resize command from the menu
get the same future as that from the tool bar. 
Furhter the dialog that comes up when you close an image. In my opinion
this dialog is horror, eather you can select to close the image or cancel
the action. I've done many mistaces when clicking the wrong button and the
work is lost. Instead the dialog should contain the de facto options with
save, don't save and cancel, where save is default action so you can just
press return to save. 

Cheers

/Daniel
Comment 1 Sven Neumann 2002-11-08 10:51:51 UTC
Please, try to use meaningful subjects for your bug reports and please
submit separate bug-reports for different and unrelated problems
Comment 2 Sven Neumann 2002-12-02 18:02:11 UTC
Changed the report summary to something more meaningful... If I
rememember correctly there is code that is supposed to draw a progress
bar when an image is scaled. Perhaps it needs to be improved.
Comment 3 Alan Horkan 2003-07-23 18:40:58 UTC
Changes at the request of Dave Neary on the developer mailing list.  
I am changing many of the bugzilla reports that have not specified a target
milestone to Future milestone.  Hope that is acceptable.  
Comment 4 Sven Neumann 2003-11-25 17:47:36 UTC
We should probably add a GimpProgressFunc pointer to the scale, resize
and rotate methods of GimpItem. At the moment only GimpItem::transform
has this API and is able to give progress feedback.
Comment 5 Sven Neumann 2003-11-25 17:49:47 UTC
Actually GimpItem::scale would probably be sufficient since resize,
rotate and flip are reasonably fast even on larger drawables.
Comment 6 Sven Neumann 2004-02-09 00:12:57 UTC
There's some room for improvement here when it comes to accuracy of
the progress bar, but this should fix it good enough:

2004-02-09  Sven Neumann  <sven@gimp.org>

  * app/core/gimpitem.[ch]: added progress callback pointers to
  gimp_item_scale() and its variants.

  * app/core/gimpchannel.c
  * app/core/gimpdrawable.c
  * app/core/gimpimage-scale.c
  * app/core/gimplayer.c
  * app/core/gimpselection.c
  * app/gui/layers-commands.c97999
  * app/paint-funcs/paint-funcs.[ch]
  * app/vectors/gimpvectors.c
  * tools/pdbgen/pdb/layer.pdb: changed accordingly. Fixes bug #97999

  * app/pdb/layer_cmds.c: regenerated.