GNOME Bugzilla – Bug 96634
support RTL flipping for progress bars
Last modified: 2011-02-04 16:11:52 UTC
Moving all the RTL flipping bugs to the 2.4.0 milestone; in some cases the changes should be easy to do. (GtkPaned comes to mind) In those cases, we can move the bugs back to 2.2.0 if patches occur.
Progress bars turned out to be the lowest-hanging RTL fruit... What the patch does is that it effectively changes the semantics of GTK_PROGRESS_LEFT_TO_RIGHT and GTK_PROGRESS_RIGHT_TO_LEFT to mean with-the-text-direction and against-the-text-direction. The question is if this is ok or if we should leave the old fixed orientations and add two new orientations which would depend on the text direction. Opinions ? Also the question arises whether these orientation-properties should be more unified between the various orientable widgets (e.g. the range widgets have horizontal/vertical + inverse, but always react to the text direction, ie there is no way to have a fixed left-to-right range independent of the text direction).
Created attachment 11794 [details] [review] patch
We already do this type of reinterpretation for GtkTextTag::justification, so it should be OK here. (I thought we did it for labels as well, but I don't see it.) It's especially OK here because specifying an orientation of horizontal-but-opposite-from-the-default is something that makes no sense to me.
So, is the patch OK for 2.2 (with corresponding doc amendmends) ?
Created attachment 11880 [details] [review] slightly revised patch
Yeah should be fine. Doc ammendments are probably a good idea, though it will doubtless confuse some people to document that left might be right and right might be left :-)