After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 96634 - support RTL flipping for progress bars
support RTL flipping for progress bars
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.1.x
Other other
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 76219
 
 
Reported: 2002-10-23 18:15 UTC by Matthias Clasen
Modified: 2011-02-04 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (3.34 KB, patch)
2002-10-23 21:59 UTC, Matthias Clasen
none Details | Review
slightly revised patch (3.23 KB, patch)
2002-10-27 23:04 UTC, Matthias Clasen
none Details | Review

Description Matthias Clasen 2002-10-23 18:15:57 UTC

Comment 1 Owen Taylor 2002-10-23 19:08:06 UTC
Moving all the RTL flipping bugs to the 2.4.0 milestone; in some
cases the changes should be easy to do. (GtkPaned comes to mind)
In those cases, we can move the bugs back to 2.2.0 if patches occur.
Comment 2 Matthias Clasen 2002-10-23 21:57:29 UTC
Progress bars turned out to be the lowest-hanging RTL fruit...
What the patch does is that it effectively changes the semantics
of GTK_PROGRESS_LEFT_TO_RIGHT and GTK_PROGRESS_RIGHT_TO_LEFT to mean
with-the-text-direction and against-the-text-direction. The question is
if this is ok or if we should leave the old fixed orientations and add
two new orientations which would depend on the text direction.
Opinions ? Also the question arises whether these
orientation-properties should be more unified between the various
orientable widgets (e.g.
the range widgets have horizontal/vertical + inverse, but always react
to the text direction, ie there is no way to have a fixed left-to-right
range independent of the text direction).
Comment 3 Matthias Clasen 2002-10-23 21:59:31 UTC
Created attachment 11794 [details] [review]
patch
Comment 4 Owen Taylor 2002-10-23 22:39:46 UTC
We already do this type of reinterpretation for 
GtkTextTag::justification, so it should be OK here.

(I thought we did it for labels as well, but I don't see it.)

It's especially OK here because specifying an orientation of
horizontal-but-opposite-from-the-default is something
that makes no sense to me.

Comment 5 Matthias Clasen 2002-10-24 06:31:56 UTC
So, is the patch OK for 2.2 (with corresponding doc amendmends) ?
Comment 6 Matthias Clasen 2002-10-27 23:04:51 UTC
Created attachment 11880 [details] [review]
slightly revised patch
Comment 7 Owen Taylor 2002-11-01 22:59:21 UTC
Yeah should be fine. Doc ammendments are probably a good idea,
though it will doubtless confuse some people to document that
left might be right and right might be left :-)