After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 96633 - support RTL flipping in stock icons
support RTL flipping in stock icons
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: [obsolete] stock-icons
2.1.x
Other other
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 76219
 
 
Reported: 2002-10-23 18:14 UTC by Matthias Clasen
Modified: 2011-02-04 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch flipping GOTO_FIRST, GOTO_LAST and JUMP_TO (2.54 KB, patch)
2002-10-31 20:29 UTC, Matthias Clasen
none Details | Review
stock_jump_to_rtl_16.png (551 bytes, image/png)
2002-10-31 20:30 UTC, Matthias Clasen
  Details
stock_jump_to_rtl_24.png (1.07 KB, image/png)
2002-10-31 20:31 UTC, Matthias Clasen
  Details
patch which additionally flips UNDO and REDO (5.12 KB, patch)
2002-10-31 20:58 UTC, Matthias Clasen
none Details | Review
stock_undo_rtl_16.png (503 bytes, image/png)
2002-10-31 21:00 UTC, Matthias Clasen
  Details
stock_undo_rtl_24.png (717 bytes, image/png)
2002-10-31 21:01 UTC, Matthias Clasen
  Details
stock_redo_rtl_16.png (488 bytes, image/png)
2002-10-31 21:04 UTC, Matthias Clasen
  Details
stock_redo_rtl_24.png (791 bytes, image/png)
2002-10-31 21:05 UTC, Matthias Clasen
  Details
libgnomeui-stock.tar (110.00 KB, application/octet-stream)
2003-06-07 00:29 UTC, Jakub Steiner
  Details
stock-part.tar (40.00 KB, application/octet-stream)
2003-06-07 00:38 UTC, Jakub Steiner
  Details

Description Matthias Clasen 2002-10-23 18:14:43 UTC
all stock icons for which the direction is important should 
be verified and if needed mirrored depending on the direction
Comment 1 Owen Taylor 2002-10-23 19:08:21 UTC
Moving all the RTL flipping bugs to the 2.4.0 milestone; in some
cases the changes should be easy to do. (GtkPaned comes to mind)
In those cases, we can move the bugs back to 2.2.0 if patches occur.
Comment 2 Matthias Clasen 2002-10-30 08:56:44 UTC
Owen already fixed forward and back (see bug 92211), but I think 
all icons involving 
horizontal arrows need similar treatment. 
These
are:

certainly:
GTK_STOCK_GOTO_FIRST
GTK_STOCK_GOTO_LAST

probably:
GTK_STOCK_JUMP_TO
GTK_STOCK_QUIT

maybe:
GTK_STOCK_REDO
GTK_STOCK_REVERT_TO_SAVED
GTK_STOCK_UNDELETE
GTK_STOCK_UNDO

probably 
not:
GTK_STOCK_OK
GTK_STOCK_REFRESH

Go to 

http://developer.gnome.org/doc/API/2.0/gtk/gtk-stock-items.html
for a 
quick overview of the stock icons.

I probably need help from artists and native 
RTL speakers for progress on this (beyond fixing goto_first/goto_last).
Comment 3 Matitiahu Allouche 2002-10-30 16:00:21 UTC
I am a Hebrew speaker, and a developer specialised in i18n matters.
My advice is that the following stock icons must be swapped, but only 
when the whole geometry of the window is made RTL (I omit the 
GTK_STOCK prefix common to all items):

GOTO_FIRST <==>  GOTO_LAST
GO_BACK  <==>  GO_FORWARD
JUMP_TO
REVERT_TO_SAVED

UNDO and REDO are debatable.  They are not symmetrized in the Hebrew-
localized GUI for MS Word, so it is probably best to leave them as-is.


I have a vaguely related suggestion: it seems that gtk supports 
JUSTIFY_LEFT and JUSTIFY_RIGHT.  I suggest to add JUSTIFY_START and 
JUSTIFY_END.  JUSTIFY_START is equivalent to JUSTIFY_LEFT in a LTR 
geometry, and to JUSTIFY_RIGHT in a RTL geometry.  JUSTIFY_END is the 
opposite.

Matitiahu Allouche
Comment 4 Matthias Clasen 2002-10-31 19:51:22 UTC
But REVERT_TO_SAVED, UNDELETE and UNDO all share the same arrow to
indicate a "undo"-kind of operation. So if we flip one of them, we
surely have to flip all for consistency ? And then we also have to
flip REDO, since the main feature of REDO is that its arrow is in the
opposite direction to UNDO...

You don't think that QUIT should be flipped ?
Comment 5 Matthias Clasen 2002-10-31 20:29:09 UTC
Created attachment 11944 [details] [review]
patch flipping GOTO_FIRST, GOTO_LAST and JUMP_TO
Comment 6 Matthias Clasen 2002-10-31 20:30:06 UTC
Created attachment 11945 [details]
stock_jump_to_rtl_16.png
Comment 7 Matthias Clasen 2002-10-31 20:31:23 UTC
Created attachment 11946 [details]
stock_jump_to_rtl_24.png
Comment 8 Matthias Clasen 2002-10-31 20:46:07 UTC
I'm going to attach a patch which additionally flips UNDO and REDO; it
should probably not be applied without also flipping UNDELETE and
REVERT_TO_SAVED (for consistency reasons as explained above). 

However, properly flipping UNDELETE and REVERT_TO_SAVED is probably
impossible without the .xcf sources, which I don't have...

Maybe some of the famous gnome artists can come to my rescue here...
Comment 9 Matthias Clasen 2002-10-31 20:58:50 UTC
Created attachment 11947 [details] [review]
patch which additionally flips UNDO and REDO
Comment 10 Matthias Clasen 2002-10-31 21:00:53 UTC
Created attachment 11948 [details]
stock_undo_rtl_16.png
Comment 11 Matthias Clasen 2002-10-31 21:01:38 UTC
Created attachment 11949 [details]
stock_undo_rtl_24.png
Comment 12 Matthias Clasen 2002-10-31 21:04:16 UTC
Created attachment 11950 [details]
stock_redo_rtl_16.png
Comment 13 Matthias Clasen 2002-10-31 21:05:09 UTC
Created attachment 11951 [details]
stock_redo_rtl_24.png
Comment 14 Matthias Clasen 2002-11-02 00:19:06 UTC
First patch (FIRST, LAST, JUMP_TO) committed now.
Comment 15 Matthias Clasen 2002-11-29 08:25:06 UTC
Any chance to get hold of .xcfs for UNDELETE and REVERT_TO_SAVED, or 
for versions 
with flipped arrows ?
Comment 16 Matthias Clasen 2003-02-22 00:38:56 UTC
Removing PATCH, as all attached patches have been committed. Still
waiting for a word from the artists...
Comment 17 Jakub Steiner 2003-06-07 00:29:27 UTC
Created attachment 17261 [details]
libgnomeui-stock.tar
Comment 18 Jakub Steiner 2003-06-07 00:37:06 UTC
Oops, why did I attach _that_? Too late I guess ;) Proper set follows
Comment 19 Jakub Steiner 2003-06-07 00:38:02 UTC
Created attachment 17263 [details]
stock-part.tar
Comment 20 Soren Sandmann Pedersen 2003-06-07 09:33:38 UTC
Wouldn it make sense to actually distribute the .xcf's with gtk+? It 
seems reasonable to ship with the "source" to the stock icons.
Comment 21 Matthias Clasen 2003-06-07 09:39:46 UTC
Thanks Jakub. I have delivered all needed rtl variants to HEAD now.