After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 96626 - Support RTL flipping for toolbars
Support RTL flipping for toolbars
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.1.x
Other other
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 76219
 
 
Reported: 2002-10-23 17:59 UTC by Matthias Clasen
Modified: 2011-02-04 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flippability for the toolbar (2.90 KB, patch)
2002-10-24 23:08 UTC, Matthias Clasen 		none Details | Review
revised patch (3.10 KB, patch)
2002-10-27 23:02 UTC, Matthias Clasen 		none Details | Review

Description Matthias Clasen 2002-10-23 17:59:04 UTC 






Comment 1


Owen Taylor





          2002-10-23 19:08:07 UTC
        



Moving all the RTL flipping bugs to the 2.4.0 milestone; in some
cases the changes should be easy to do. (GtkPaned comes to mind)
In those cases, we can move the bugs back to 2.2.0 if patches occur.







Comment 2


Matthias Clasen





          2002-10-24 23:08:38 UTC
        



Created attachment 11817 [details] [review]
flippability for the toolbar






Comment 3


Owen Taylor





          2002-10-26 21:12:15 UTC
        



Same comment as gtkmenubar for assigning back and forth
between ltr_x and alloc.x; there also are a couple of
misplaced { - e.g.:

+	  if (toolbar->orientation == GTK_ORIENTATION_HORIZONTAL) {

Other than that, the patch looks fine.









Comment 4


Matthias Clasen





          2002-10-27 23:02:16 UTC
        



Created attachment 11879 [details] [review]
revised patch






Comment 5


Owen Taylor





          2002-11-01 22:44:52 UTC
        



Looks good to commit.