After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 96124 - Gnome terminal does not follow 'application font'
Gnome terminal does not follow 'application font'
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other opensolaris
: Normal major
: ---
Assigned To: Havoc Pennington
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-10-18 01:07 UTC by Hidetoshi Tajima
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.0



Description Hidetoshi Tajima 2002-10-18 01:07:24 UTC
In terminal preferences, select "Use same font as other application" then
change the Application Font in 
Preferences -> Font.  Nothing happens.

This is due to make_font_monospace() which has
"FIXME" comment.
Comment 1 Havoc Pennington 2002-10-18 04:03:16 UTC
The fixme is for the pango case, which should work, despite the fixme.
what probably doesn't work is make_xfont_monospace.

Are you using zvt or vte, and with core X fonts, Xft1, or Xft2?
Comment 2 Hidetoshi Tajima 2002-10-18 04:23:58 UTC
I'm using libzvt of libzvt-i18n with gnome-terminal
from gnome-2-0 branch + a patch to enable pango 
font for libzvt case. libzvt-i18n converts 
PangoFontDescripion to X11 fonts, though.

make_font_monospace(term->style->font_desc) always
return NULL, and then it goes into
 desc = pango_font_description_copy (terminal_profile_get_font (profile));

Does it mean it always use terminal's font setting , and ignore
system's settings?
Comment 3 Havoc Pennington 2002-10-18 06:12:36 UTC
You'll probably need to dive into pango a bit and see why 
there's no font which is like the system font but called "monospace"...

Of course, with the Font control panel containing a terminal font 
now, it's unclear we still need the "use system font" option.
Comment 4 Hidetoshi Tajima 2002-10-18 16:05:30 UTC
But, will you please answer why return NULL
below?

In src/terminal-screen.c:

make_font_monospace (const PangoFontDescription *font)
{
  PangoFontDescription *ret;

  return NULL;     <=== ??

  ret = pango_font_description_copy (font);

  /* FIXME */
  pango_font_description_set_family (ret, "monospace");

  return ret;
}
Comment 5 Hidetoshi Tajima 2002-10-18 16:55:43 UTC
gnome-terminal starts repsonding to "use system font" after removing
this return NULL line.

Is this change okay to commit to both branches?
Comment 6 Havoc Pennington 2002-10-18 17:08:39 UTC
Oh, no clue. I didn't notice that. ;-)

Yes, please commit. Though on HEAD I think we may just nuke this setting 
eventually, it may as well work while it's there.
Comment 7 Hidetoshi Tajima 2002-10-18 17:24:48 UTC
commit to both branches. Thanks!

	* src/terminal-screen.c (make_font_monospace):
	  Fix #96114: to responce to "use system font" option