Shouldn't the default owner of this module change?

Created attachment 12041 [details] [review]
lame patch

Icky.  I would almost favor parsing the keys in entry_new() and
returning NULL if OnlyShowIn != GNOME.

Fine with me. I don't really have a global understanding of this code,
so just put in what seemed like the simple/obvious hack.

Targeting this at 2.2, if possible, alex.

Alex rejected the patch so technically PATCH should be removed ...

Looking at this more, I think making entry_new() return NULL 
would not work at all - then you wouldn't notice changes to the 
.desktop file. You need to load the entry, just exclude it from 
queries, which is what my patch does, though granted it could 
probably be done better in the details.

Removing PATCH

I had put PATCH back on purpose, because I think my patch is right, 
what Alex suggested instead is wrong IMO.

I defer to hp on vfolder changes. If you think it's right, check it in.

<ping>

Havoc, if you think this should be applied will you commit it like
Alex suggested?

The bug is still present in Gnome 2.3.90. In the mean time, the
desktop file spec now also has a NotShowIn field which should be
honored too.

Please see bug #121791 for a longer description of why I think it's a
critical bug.

I attach patch for gnome-vfs2 with #121791

Closing this since the vfolder method has been removed. Please file bugs against
gnome-menus if this is still a problem in 2.9.x