After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 93562 - gnome_vfs_xfer_uri() documentation is wrong
gnome_vfs_xfer_uri() documentation is wrong
Status: RESOLVED WONTFIX
Product: gnome-vfs
Classification: Deprecated
Component: Docs
unspecified
Other other
: Normal normal
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
: 165739 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-09-18 09:55 UTC by mawarkus
Modified: 2008-09-06 19:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch that fixes most of the documentation issues with this function (7.17 KB, patch)
2005-02-17 10:50 UTC, Olivier Sessink
none Details | Review
XferOptions patch (4.67 KB, patch)
2005-07-08 10:33 UTC, Paolo Borelli
none Details | Review

Description mawarkus 2002-09-18 12:11:24 UTC
Package: gnome-vfs
Severity: normal
Version: 2.0.4
Synopsis: gnome_vfs_xfer_uri() documentation is wrong
Bugzilla-Product: gnome-vfs
Bugzilla-Component: Docs

Description:
The doc string for gnome_vfs_xfer_uri() seems to get a lot wrong, for
example the meanings of GNOME_VFS_DELETE_ITEMS and such




------- Bug moved to this database by unknown@bugzilla.gnome.org 2002-09-18 08:11 -------

The original reporter (mawarkus@t-online.de) of this bug does not have an account here.
Reassigning to the exporter, unknown@bugzilla.gnome.org.
Reassigning to the default owner of the component, gnome-vfs-maint@bugzilla.gnome.org.

Comment 1 Ian McKellar 2002-09-18 18:33:31 UTC
The guy who was documenting this didn't have much experience with the
code, so its possible (likely even) that there are some mistakes. I
would love it if you could tell me whats wrong so I can fix it. I
don't really know the xfer API either.
Comment 2 Matthias Warkus 2002-09-24 22:23:45 UTC
GNOME_VFS_XFER_RECURSIVE does not mean "copy recursively", it just
means "whaetever we'll do, recurse when snarfing the source file list"

GNOME_VFS_XFER_DELETE_ITEM: this does *not* mean a mv; this means
"delete the source file list", and asserts that the destination list
is empty!

GNOME_VFS_XFER_REMOVESOURCE: settings this means the source files will
be removed after the operation -- this means a mv

GNOME_VFS_XFER_EMPTY_DIRECTORES: will empty the directories in the
source list, asserts destination list is empty

GNOME_VFS_XFER_USE_UNIQUE_NAMES: does not mean "transfer only unique
items" -- this means "at name collision, ask back so files won't be
overwritten, but named uniquely"

GNOME_VFS_XFER_NEW_UNIQUE_DIRECTORY: description is utter hogwash;
what this does is create exactly one unique new directory; asserts
source list has exactly 1 entry and destination list is empty

GNOME_VFS_XFER_LINK_ITEMS: means link instead of copy

BTW, the layout of that documentation page is also very broken and
hard to read. I can fix this if you want to, as soon as I'm done with
the book
Comment 3 Kjartan Maraas 2003-10-29 14:25:54 UTC
Reopening. Is this still relevant to the current behaviour?
Comment 4 Christian Kellner 2005-02-05 21:40:28 UTC
*** Bug 165739 has been marked as a duplicate of this bug. ***
Comment 5 Christian Kellner 2005-02-05 21:44:01 UTC
Moving over the comments from bug 165739:

[From Olivier Sessink] 
the docs for gnome_vfs_async_xfer are somewhat fuzzy, I'll try to explain the
issues:

1) GnomeVFSAsyncXferProgressCallback is not linked (from the html docs), I
looked it up in the gnome-vfs-async-ops.h file. In that file it sais the
callback should always return 0, except if status is GnomeVFSXferErrorAction or
GnomeVFSOverwriteAction.

2) GnomeVFSXferProgressCallback is in the html docs, but without description

3) both callbacks return gint, it seems unlogical that both have to pass the
user descision to gnome_vfs, so what should the return value be for both of the
functions?

4) returning 0 by default (as written in gnome-vfs-async-ops.h) seems to abort
all transfer

5) it *seems* (after some debugging, and looking at nautilus code) that the
progress_sync_callback is the callback that should pass the user descision to
gnome_vfs (please check this first)

another (only slightly related) issue:
the html index does not show the async functions. You have to click 'file
operations' and click 3 times 'next' to get to those functions

Comment 6 Olivier Sessink 2005-02-17 10:50:43 UTC
Created attachment 37587 [details] [review]
patch that fixes most of the documentation issues with this function

I don't know how gtk-doc works, so I did not build the new documentation, so
this is not tested.
Comment 7 Paolo Borelli 2005-07-08 10:33:25 UTC
Created attachment 48823 [details] [review]
XferOptions patch

This is orthogonal to Olivier's stuff: it just takes care of moving all the
xfer options explanation along the enum where it belongs and also rectifies the
wrong informations pointed out in comment #2.
Comment 8 Tristan Hill 2005-08-11 10:22:46 UTC
there is also typo in the description of the data parameter of gnome_vfs_xfer_uri()

data :	 Data to be want passed back in callbacks from the xfer engine
Comment 9 Claudio Saavedra 2006-06-04 12:12:00 UTC
Is there any update on this? I need to use the Xfer API and am a little confused by the documentation and now a bit more because of this bug report.
Comment 10 André Klapper 2008-09-06 19:12:03 UTC
gnome-vfs has been deprecated and superseded by gio/gvfs since GNOME 2.22, hence mass-closing many of the gnome-vfs requests/bug reports. This means that gnome-vfs is NOT actively maintained anymore, however patches are still welcome.

If your reported issue is still valid for gio/gvfs, please feel free to file a bug report against glib/gio or gvfs.

@Bugzilla mail recipients: query for gnome-vfs-mass-close to get rid of these notification emails all together.


General further information: http://en.wikipedia.org/wiki/GVFS 
Reasons behind this decision are listed at http://www.mail-archive.com/gnome-vfs-list@gnome.org/msg00899.html