GNOME Bugzilla – Bug 93496
Can't override toolbar layout anymore
Last modified: 2004-12-22 21:47:04 UTC
With galeon 1 I could choose how bookmarks were displayed in bookmark toolbars ("Icon only", "Text only", "Text beside icon", and "Text beneath icon"). This has siappeared in galeon2
Does Galeon depend on Gnome 2's "toolbar settings" for bookmarks now? If so, does this make this bug report closed? Steve Griff
IMHO it shouldn't depend on that. A bookmark toolbar isn't really a toolbar (Except in implementation), it's just a more useful than normal view into the users bookmarks.
It does not depend on gnome prefs for _bookmarks_ toolbars. It only has one mode implemented for them. I want to implement the other modes and allow per toolbar selection, like in galeon 1. But I don't know if I will do it before galeon 2.0
The following patch should be a step to some direction. It allows one to change the toolbar layout by modifying a gconf option. The gconf key should be compatible with g1. Please comment. If the patch is fine, then someone should add an optionmenu to the toolbar editor for changing the toolbar layout without the need to dig through gconf.
Created attachment 12782 [details] [review] Change the toolbar layout using a gconf pref
Erm, no sorry you've missed the point. This patch seems to change the appearance of the navigation toolbar. The normal toolbar does (AFAIK), and should follow the GNOME preference for toolbar appearance. This bug was raised about "Bookmark toolbars" which: a) Don't follow the GNOME setting b) Shouldn't (IMO) because they're a different metaphor c) Used to be configurable, but aren't now If you can make the patch apply to bookmark toolbars, not the standard navigation toolbar then we're getting there.
Following is an updated patch that doesn't extend the range of values in the key, instead if the key is unset the desktop default is used. This way we don't need to rename the key ;) Ric, ok to apply? We'd just need the UI ;)
Created attachment 14469 [details] [review] Updated patch
I'm a bit uncomfortable giving a special meaning to an unset preference. I would prefer adding another value or if we want to keep compatibility with galeon1 adding a different key called /apps/galeon/UI/Toolbar/toolbar_style_use_system_default, of type boolean and defaulting to TRUE. Apart of that, please apply.
Consider that the preference is an override for the desktop default. It only makes sense that when the override is unset, there is no override and desktop default is used. OTOH, adding a value 'use desktop default' creates an override with a meaning "no, don't use desktop default, use desktop default instead" ...doesn't make much sense to me. Anyway, I'll commit the patch, close this bug and open a new one to address the original problem again (sorry lwillis)
Fixed in CVS. Moved to bug 106608 and this time I'll try to not confuse everyone :)