GNOME Bugzilla – Bug 92852
Icons in the Applications menu and Applet icons in the "Add to Panel" menu not resizing
Last modified: 2004-12-22 21:47:04 UTC
Running with the latest icon-sizing patch in bug #70648, starting from default theme: - Choose a large-icon theme, e.g. HighContrastLargePrint: all panel menu icons get bigger - Choose the default theme again All panel menu icons get smaller *except* the third level ones on the panel menu, e.g. Add to Panel->Internet->Inbox Monitor. The third level icons on the Apps & Actions menus resize fine. Sometimes you have to alternate between themes a couple of times before this happens-- I think you actually have to open the affected menu after each theme change to make the icon render before things get out of sync. Not sure if this is a panel bug (third level icons not respecting panel-menu size?) or an icon-sizing patch bug, but filing it here first for a bit of variety :)
One thing worth noting is that all the icons that have problems are all applets, which is perhaps a bit more telling than simply saying that "third-level" panel menu icons are not resizing. I notice that if you go to the menu, pick "Add to Panel" and then "Launcher from Menu" that these icons are also "third-level" but they are all sizing properly. A difference is that these working "third-level" icons are not for applets.
Hmm, I'd imagine this happens with launcher icons too no ? If you look at load_icons_handler, if its not an icon with a stock id we scale the pixbuf there and then an set the pixbuf on the GtkImage. We probably need to be notified of the icon size change and re-scale the icon. Actually, we probably need to look up the icon according to the icon theme spec again ... Anyway, this bug doesn't exist in the community yet really since #91686 hasn't been resolved. Making this bug depend on #91686.
Hmm... which launcher icons, Mark? On Solaris it works fine for all the other launcher icons on the Application and panel menus. (The Actions menu works fine too, but it's all stock icons). Oddly enough, though, on my RH7.2 box the top level Application menu icons don't resize either, but the Add to Panel submenu icons do. (The sub-sub-menu icons don't though, as in the original report above!). Raj also sees this problem on his RH7.1 box, both with the most recent icon-sizing sun-patch. But IIRC Brian told me it worked fine on Sun Linux. Anyone have any ideas what might be causing the discrepancy between the platforms?
Oh hang on, the Add to Panel submenu icons are all stock icons too. So it looks like Mark is right-- none of the menu launcher icons are reszing for me or for Raj on Linux. This doesn't explain why it works fine (bar the third-level icons) on Solaris, though ... what's going on there?!
strange ... you're right about the Actions menu being stock icons of course - updating the title to reflect that
I now see similar but different behavior with Owen's icon sizing patch, on both RH7.2 and Solaris: - Change to a large font theme (e.g. LargePrint), all icons on the panel menus except the ones on the top level of the Applications menu get bigger - Change back to default theme (say); none of the icons on panel menus get smaller again. Can anybody else confirm they're seeing this too?
All these problems seems to be rectified with Owen's fix (on RH7.2 anyway, haven't tried on Solaris yet), now that the accessible themes are updated to specify 'gtk-dnd' rather than 'dnd' in their gtkrc files. Mark, suggest you test this yourself with latest gnome-themes... assuming you're happy with the results we can close this one.
I take it back, bug #94610 was masking this one :/ I still see that various icons on the Applications menu (all top-level ones, plus those on the Accessories submeu) don't resize when switching to a LargePrint theme, yet all the other icons on all other panel menus do.
NB at least I'm seeing the same bug consistently on RH and Solaris now, which is good or bad depending on how you look at it :)
*sigh* the synchronicity didn't last long. - In the latest Solaris nightly branded build (Oct 8th), icon sizing works perfectly, including on the Applications menu. - In the latest Solaris stable build (11), which also has Owen's complete icon sizing fix in it, John showed me the Apps menu problem *plus* icon sizing not working generally in gtk when you try to go back from large->normal icons. On Solaris 8, build 11 is so broken that I can't login so I can't check this for myself... - In my hand-rolled linux build, last updated Oct 7th, I see the Applications menu problem, but icon sizing works fine everywhere else. Brian N., Shane, everyone, can you please try this on as many different builds/platforms as possible and try and detect a pattern because it's driving me round the twist :)
I withdraw my remark about it "working perfectly" in the nightly, too... the Applications menu works perfectly, but the Add to Panel submenu doesn't...
I've tried this on Solaris 9 with build11:- o change to HighContrastLargePrint theme o change back to default theme Result ------- The following icons do not resize back to default (i.e. they retain large icons) - All CDE Menu - All Actions Menu - Most of the Right-click Panel menu o main pop-up menu and 1st sub-menu retain large icons o 2nd sub-menu has small icons with the exception of the CDE Menu under "Add to Panel:Launcher from Menu" I also noticed that now if a "Lock" button is added to or already exists on the panel when I right-click on the lock button the pop-up menu is oversized (even though no icons are displayed). Restarting gnome-panel will return to the default.
In addition to the problems reported by Shane, I have noticed that mneu items do not resize even when the icons do.
The LargePrint theme specifies a value for gtk-icon-sizes but the Default theme does not. When one witches from LargePrint theme to Default theme the gtk-icon-sizes property og GtkSettings is not updated, or at least no notification of the update is emitted. So the gtk-icon-sizes for LargePrint continue to be used. Transferring to gtk+ for help on evaluation.
This behaviour seems to be what bug 94610 fixes. I need to test with a version with the fix for 94610.
I have applied the changes for bug 94610 to my version of GTK+ and now the panel does not obey the LargePrint theme at all.
Padraig - you probably don't have a sufficiently new version of Pango; you need Pango-1.0.5 or Pango-1.1.2, or current CVS of either branch.
The pango I have is from pango-1-0 branch as of October 15th so is pango 1.0.5 +. What made you suspect that pango may be the problem?
There was a Pango bug that caused problems for the icon size code. If that's not it, I don't have any ideas. The icon theme size switching worked well for me in fairly extensive testing. I haven't tested things with the panel menus -- it is not unlikely that the panel may have panel-specific problems in this area that will have to be addressed in the panel.. As long as it works with testgtk, I don't think this bug should be assigned to gtk+.
Reassigning back to the panel
I have corrcted my application of the changes for bug 94610 and this bug does not now occur. I am closing this bug as a duplicate of bug 94610. *** This bug has been marked as a duplicate of 94610 ***
Just installed Sun build fcs-02 and this problem is still occurring. (It didn't happen for me in fcs-01, although its appearance and disappearance was always kind of random between builds so I'm not sure that counts for anything...)
Created attachment 12227 [details] [review] Proposed patch
adding some keywords.
Padraig: patch looks fine - feel free to commit.
Patch applied.
I think this bug may still be alive, I am still seeing it. Marking NEEDINFO while I confirm on HEAD.
Bill, please don't do things like this until you've confirmed that the bug hasn't been fixed. Also, if you do confirm this and re-open, please re-state exactly what the problem you're seeing now is. Thanks.
I can confirm that this is still a problem, see attached screenshot from yesterday's build from HEAD, showing that with the HighContrastLargePrint gtk theme selected, only the KDE Menu icon on the Applications menu is correctly scaled.
Created attachment 15461 [details] Screenshot showing menu icons not scaling properly
A couple of different people have spent time on this one now without any success, and it's a pretty obvious/critical bug for accessibility... trouble is it doesn't behave consistently, which might point to a nasty race condition or something. Anyone interested in many free pints at GU4DEC, please try to fix this one ASAP!!
(Viewers be warned: getting free pints out of scottsmen is historically more than a little difficult :-)
Does this problem occur if a therme is chosen in the Theme Preferences window ot does it only happen when the Theme Details window is used?
When the theme is changed using the Controls tab in the Theme Details window the function icon_theme_changed, the signal handler for "changed"signal on a GnomeIconTheme is not called.
The Controls theme controls the appearance of the CDE Menu Icon as it is a stock icon. The Icons Theme controls the appearance of the other icons in the Application menu. If the Icons theme is updated the other icons grow in size. One must also change the font size manually. I do not think that this is a bug in gnome-panel. I would regard this as a usability bug in gnome-theme-manager.
Hi guys: "RESOLVED" doesn't capture the status of this horrible bug IMO. It seems to me that the end-user behavior is still badly broken. Is that not right? If so, please open new high-priority bug, or transfer this one, but don't just leave this closed as if there was never a problem (i.e. NOTABUG), that's bogus.
I will open a new bug.
The bug I opened is 114393.