After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 89850 - Metacity doesn't set skip_panel and skip_tasklist hints
Metacity doesn't set skip_panel and skip_tasklist hints
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2002-08-04 18:17 UTC by Ross Burton
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (1.77 KB, patch)
2002-08-04 18:19 UTC, Ross Burton 		none Details | Review
New patch (1.56 KB, patch)
2002-08-05 11:37 UTC, Ross Burton 		none Details | Review

Description Ross Burton 2002-08-04 18:17:43 UTC 
If an application sets the SKIP_PAGER or SKIP_TASKLIST hints on a window,
metacity updates its internal status but does not push the atoms.

This is due to the two flags, window->skip_pager and
window->net_wm_skip_pager, being used inconsistantly.  A patch I'm about to
attach fixes this by setting both of these flags when a client notification
event comes in.
Comment 1 Ross Burton 2002-08-04 18:19:52 UTC 
Created attachment 10247 [details] [review]
Fix
Comment 2 Havoc Pennington 2002-08-04 18:26:54 UTC 
The patch is slightly wrong, the client message should change only 
wm_state_* (see comments in front of the struct fields in window.h)
and window->skip_pager etc. should be set in recalc_window_features.

So just s/skip_pager/wm_state_skip_pager/ in the client message
processing function should work.
Comment 3 Ross Burton 2002-08-05 11:37:18 UTC 
Created attachment 10267 [details] [review]
New patch
Comment 4 Havoc Pennington 2002-08-05 15:07:57 UTC 
Patch looks good, feel free to commit.
Comment 5 Ross Burton 2002-08-05 15:33:03 UTC 
Done, thanks.