GNOME Bugzilla – Bug 89689
GnomeFileEntry doesn't work properly if packed in a modal window
Last modified: 2007-01-10 11:38:10 UTC
If a GnomeFileEntry is packed in a modal window, when the user click on the browse button, the file selector which appears is unresponsive since it's not modal, the user has to kill the app to exit. This issue appears in several control-center capplets (I noticed it in theme and sound capplets), that's why I marked it as major. Steps to reproduce in the theme capplet: * launch gnome-theme-properties * click install new theme * click browse * the app freezes The attached patch tests if the entry is in a modal window, and creates a modal file selector if it is (patch to come in a few minutes, it still needs some tests)
Pushing priority since it's really easy to reproduce,and makes GNOME looks unpolished.
Created attachment 10216 [details] [review] makes the file selector modal if the file entry is packed in a modal window
Is there some reason why the correct fix isn't at the application level? (all the control-center capplets are now fixed, for example.)
They weren't last time I updated, but if they are now, that's ok But I think that's a little broken to let libgnomeui create a non modal file selector when the file entry is modal since we know that will freeze the application, and it's easy to fix at the libgnomeui level. Not fixing it is a little like saying "the user of the library obviously knows that it should inform libgnomeui that its file entry is in a modal window before trying to use it". Since I don't think it's clearly stated in the documentation, and that's not really obvious what you have done wrong when you try to use a file entry and your app freeze, I think libgnomeui should have this patch and force the modality when necessary
The bugs in control center capplets are fixed, so I lower the priority and importance of the bug. But I still think it's more appropriate to put that in libgnomeui rather than have a workaround in each modal app using a file entry.
Is this still relevant?
Does the new file selector change this in any way?
Federico? Is this still relevant?
This problem still occurs, even with the new file-chooser.
The patch doesn't apply any longer. I'm uploading an updated patch for review. Christoph, does this look like it does the same thing that was intended?
Created attachment 48506 [details] [review] updated patch
Commited.