GNOME Bugzilla – Bug 89540
aisle-riot seahaven thinks game over too soon
Last modified: 2012-01-31 23:21:28 UTC
the seahaven game has a bug that makes it say "game over" too soon. --- seahaven-orig.scm 2002-07-29 18:42:22.000000000 -0400 +++ seahaven.scm 2002-07-29 18:43:55.000000000 -0400 @@ -65,7 +65,7 @@ (and (not (empty-slot? slot-id)) (or (= (length card-list) 1) (and (> slot-id 7) - (< (length card-list) (+ 2 free-reserves)) + (< (length card-list) (+ 1 free-reserves)) (check-same-suit-list card-list) (check-straight-descending-list card-list)))))
assuming this is still present in GNOME2 and upping the priority due to the patch.
Ross, Rosanna: would you mind if I made ross or gnome-games-maint the owner of this module?
I'm happy to be the official maintainer for aisleriot, as long as I am not expected to understand lisp :)
The patch is wrong. It needs to be two rather than one since it is a less than check (so it should be one more than the number of free reserves we need) and then you can move one card without any free reserves so add one more. 1 + 1 = 2. This is actually a duplicate of #65242 and the patch supplied there should fix it. It's a case of undo/restore not saving the free-reserves variable (which is kept as a running total).
Ross puts his faith in Callum... :) *** This bug has been marked as a duplicate of 65242 ***
This bug is being reassigned to the "general" component so we can close the aisleriot bugzilla component. Apologies for the mass email!