GNOME Bugzilla – Bug 88279
No Credits dialog
Last modified: 2005-08-15 01:55:38 UTC
I can't see any "Credits" button in the about window, so I can't see information about the code hackers, documenters or translators. Please add it, for great justice!
Well, I tried giving this a go, but discovered gconf-editor isn't using libgnomeui at all. andersca said he would rather add gnome-about.[ch] in gconf-editor's sources, as he doesn't want to link to gnomeui just for a stupid about dialog. When I tried doing this, I came across a maze of .h deps. Someone who knows how to chop unneeded things of these header and source files should probably finish this patch.
Created attachment 11886 [details] [review] incomplete patch (needs stripped down copy of gnome-about.[ch])
This patch needs to wait after the feature freeze, but I'm not sure this is the right way... maybe linking gconf-editor with libgnomeui and make it a gnome program is better. How many apps around there are using gtk+gconf without being gnome apps? Are they relevant for gconf-editor?
Adding the PATCH keyword.
I'm removing the PATCH keyword, as the patch is incomplete and probably quite broken. I think keeping gconf-editor just GTK could be a Good Thing. If some gconf setting broke all GNOME apps, you could still fix it up by using the GTK-only gconf-editor, to some extent.
Created attachment 26126 [details] [review] Patch using gnome_about_ This patch uses the gnome_about_new function. This depends on gconf-editor becoming a gnome app (patch on bug #133052)
Hi fer, I tend to agree with andersca's point of view of 1.5 years ago: gconf-editor might be used when GNOME-related stuff is quite broken, to try to change some gconf setting that makes it not work at all, for example. If we make gconf-editor a GNOME app, it'd be useless in this scenario, for example.
Commited.