After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 86591 - Combining Jamos support with Xft
Combining Jamos support with Xft
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: hangul
1.0.x
Other other
: Normal normal
: 1.2.0
Assigned To: Changwoo Ryu
Owen Taylor
Depends on:
Blocks:
 
 
Reported: 2002-06-27 03:56 UTC by Changwoo Ryu
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.0


Attachments
pango patch to add hangul-xft module (52.52 KB, patch)
2002-06-27 03:57 UTC, Changwoo Ryu
none Details | Review

Description Changwoo Ryu 2002-06-27 03:56:11 UTC
Now basic-xft rendering module can't shape Combining Hangul Jamos (U+1100 -
U+11FF).  A new rendering module is needed for this.  This patch adds
hangul-xft module.

Additionally I did some cleanup on hangul-x module because a few
same #defines and/or tables were shared between hangul-x and hangul-xft.
Comment 1 Changwoo Ryu 2002-06-27 03:57:01 UTC
Created attachment 9478 [details] [review]
pango patch to add hangul-xft module
Comment 2 Changwoo Ryu 2002-07-10 17:37:32 UTC
Ah no one checked whether this patch is good or not...  Maybe 
there's no guy here to understand the hangul module and this patch?

Then OK to commit this patch?  Many Korean guys have tested this version
of the patch and no one complained yet.

At least I could integrate this stuff to the HEAD, if I success to build
that correctly).
Comment 3 Owen Taylor 2002-07-10 18:11:32 UTC
No, I haven't forgotten about your patch, I'm just extremely
shortchagned for time recently.
Comment 4 Changwoo Ryu 2002-07-26 17:52:01 UTC
Some problem:

When I use "real" (not "sans" or something like) English Truetype font 
with Korean font associated, the hangul-xft module can't find Korean 
glyphs from the given font.

match   any family == "Arial"   edit family =+ "Baekmuk Gulim";

I guess some code in pango or Xft assigns different Truetype font
according to the unicode range.  Is it right?  How can I let 
hangul-xft use Hangul font for the U+1100~U+11FF range?
Comment 5 Owen Taylor 2002-07-31 19:03:24 UTC
I'm not quite sure I understand your problem. Is the problem
that your font doesn't have glyphs for the U+1100 - U+11FF 
range, but only the composed characters?
Comment 6 Owen Taylor 2002-07-31 19:08:33 UTC
I've applied your patch to the HEAD branch of Pango; I think
it might be a little big to go into stable.

 A) Could you check what I applied? There were some
    conflicts with the ksc5601.1992-3.

 B) Could you fix up the ksc5601.1992-3 code to match
    the way for the other encodings you render
    the prefix of an uncomposable Hangul syllable
    as a syllable?

Thanks.
Comment 7 Changwoo Ryu 2002-08-01 07:55:47 UTC
> I'm not quite sure I understand your problem. Is the problem
> that your font doesn't have glyphs for the U+1100 - U+11FF 
> range, but only the composed characters?

Both.  When basic-xft renders Hangul syllables correctly, hangul-xft
can't find glyphs on U+AC00~ or U+1100~.
Comment 8 Changwoo Ryu 2002-08-01 08:10:42 UTC
Now ksc5601.1992-3 code fixed in HEAD.

2002-08-01  Changwoo Ryu  <cwryu@debian.org>

	* modules/hangul/hangul-x.c (render_syllable_with_ksx1005):
	Renders the prefix of uncomposable Hangul syllable in the way of
	other font encoding code.

Well, at least is it possible some "bug fixes" go into stable?  There
are some leaks and wrong glyph selection fixed in this patch.
Comment 9 Owen Taylor 2002-11-02 05:42:38 UTC
Moving bugs to new hangul component
Comment 10 Owen Taylor 2002-12-07 01:05:42 UTC
Sorry for not responding earlier; yes bug fixes can go into
stable if you think they are safe. (Not likely to make
things get worse.) It seems that some bug fixes have
gone into stable recently. Can this bug be closed now?
Comment 11 Owen Taylor 2002-12-16 06:33:11 UTC
Closing; please reopen if that is incorrect.