After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 86330 - Focus doesn't move to clicked panel object
Focus doesn't move to clicked panel object
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: libpanel-applet
2.0.x
Other All
: High normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-06-24 11:59 UTC by Calum Benson
Modified: 2015-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix problem (1.31 KB, patch)
2002-07-02 14:53 UTC, padraig.obriain 		none Details | Review
Reworked patch (2.58 KB, patch)
2002-07-14 12:05 UTC, padraig.obriain 		none Details | Review
Correction to initialization of priv->focusable_child in previous patch (2.58 KB, patch)
2002-07-15 15:53 UTC, padraig.obriain 		none Details | Review

Description Calum Benson 2002-06-24 11:59:35 UTC 
When you click on a panel object with either mouse button, the panel's
focus ought to move to that object.  Currently, if the object doesn't
normally respond to single clicks (e.g. stock ticker, weather applet), the
focus indicator remains on whichever panel object you last gave focus to.
Comment 1 padraig.obriain 2002-07-02 14:53:44 UTC 
Created attachment 9592 [details] [review]
Patch to fix problem
Comment 2 Mark McLoughlin 2002-07-12 03:53:15 UTC 
Padraig: could you redo this to cache whether the attribute has a
focusable child ? Maybe invalidating this when the hierarchy under us
changes ? Can this be done ?

Just don't want to have to traverse the hierarchy under us every
button press.
Comment 3 padraig.obriain 2002-07-14 12:05:37 UTC 
Created attachment 9853 [details] [review]
Reworked patch
Comment 4 padraig.obriain 2002-07-14 12:06:41 UTC 
I have attached a reworked patch. I have not fogured out how to test
the situation where the hierarchy is changed.
Comment 5 padraig.obriain 2002-07-15 15:53:28 UTC 
Created attachment 9878 [details] [review]
Correction to initialization of priv->focusable_child in previous patch
Comment 6 Mark McLoughlin 2002-07-16 04:10:42 UTC 
Looks fine Padraig. Please commit and close the bug.