GNOME Bugzilla – Bug 84697
Nautilus crashes when reordering bookmarks
Last modified: 2004-12-22 21:47:04 UTC
Package: nautilus Severity: critical Version: 2.0.0 Synopsis: Nautilus crashes when reordering bookmarks Bugzilla-Product: nautilus Bugzilla-Component: Bookmarks BugBuddy-GnomeVersion: 2.0 (2.0.0) Description: Description of Problem: After playing with bookmarks, this is, reordering them using drag and drop, nautilus crashes. Steps to reproduce the problem: 1. Reorder your bookmarks 2. I can see duplicated entries in the edit dialog, but they do not appear duplicated in the Bookmarks menu in the filemanager window. 3. Actual Results: Crash Expected Results: Reorder bookmarks How often does this happen? First crash. Additional Information: I just checked out nautilus cvs head 9/6/2002. I can't remember if the patch to make reordering by dnd is applied, is this case, the patch works but there is some corruption that causes the crash. Debugging Information: Backtrace was generated from '/gnome/head/INSTALL/bin/nautilus' [New Thread 1024 (LWP 14752)] [New Thread 2049 (LWP 15247)] [New Thread 1026 (LWP 15248)] [New Thread 2051 (LWP 15249)] [New Thread 3076 (LWP 15250)] [New Thread 4101 (LWP 15251)] 0x40b4ea39 in wait4 () from /lib/libc.so.6
+ Trace 23565
Thread 6 (Thread 4101 (LWP 15251))
Thread 5 (Thread 3076 (LWP 15250))
Thread 4 (Thread 2051 (LWP 15249))
Thread 3 (Thread 1026 (LWP 15248))
Thread 1 (Thread 1024 (LWP 14752))
------- Bug moved to this database by unknown@bugzilla.gnome.org 2002-06-09 20:28 ------- Reassigning to the default owner of the component, nautilus-maint@bugzilla.gnome.org.
Confirming bug as I got a second crash. It happened just when I moved the bookmark to the top, this is, it should become the first bookmark. The backtrace for the second crash is attached.
Created attachment 9093 [details] stack trace saved from bug-buddy
'I can't remember if the patch to make reordering by dnd is applied,' What patch are you referring to? And was it applied?
see bug 80986
Ah. So, Damon, Alex: if bookmark DND is just hosed, can we disable it instead of continuing to present people with a horribly broken/crashy interface?
Manuel: were you moving items around fairly quickly? Do you have a fast machine? I don't see a problem most of the time. But if I drag items about very quickly I can get critical warnings, which is probably the same issue as the crash. I think it may be reentrancy problems. When the bookmarks are changed nautilus does a lot of Corba stuff updating the bookmarks menu etc. So if you drag another item while it is in the middle of this, it can get confused. I may be able to fix it so that it is in a stable state before it starts doing all the Corba stuff. So it shouldn't get confused.
this could indicate that 72723 wasn't fixed
Indeed, Jacob's patch to make the bookmark list a GtkListStore was never committed. Which is a shame, as it is the better way to fix this.
I have a P3 - 533. Playing with it a bit more I have noticed that you are rigth. The best way to reproduce it is to continously drag third row to be second as fast as possible. This makes a crash in a short time, perhaps some other app using the cpu helps. Tell me if there is any patch to try.
So whats the status on this? Should jacob's patch be commited? Will this crash still exist afterwards?
campd and I decided that I'd try to fix this first, if it is easy to do, and if that didn't work we'd thing about the other patch. The related bug is bug 72723.
I haven't been able to figure out what is going on here. It is a bit odd - sometimes when opening the dialog it adds all bookmarks twice. So I think we'll have to go for the list store. Marking as a dup. *** This bug has been marked as a duplicate of 72723 ***