GNOME Bugzilla – Bug 84463
Use infobar for scripts directory instead of dialog
Last modified: 2012-09-19 18:19:42 UTC
Hey, There is no way to "disable" the "About Scripts"-dialog shown when opening the scripts folder. It's very annoying to see it every time - there should be a "don't show this again" checkbox or something.
This is still true for nautilus version 2.2.2 (Debian/unstable). I am changing the GNOMVER keyword to "GNOMEVER2.2".
Still true with Nautilus 2.4.1 => GNOMEVER2.4
*** Bug 312400 has been marked as a duplicate of this bug. ***
See also Bug 329906
I think we should just use an infobar for this directory that allows going to the documentation.
Created attachment 221088 [details] [review] Add a clue bar to special locations like Templates and scripts
Created attachment 221089 [details] [review] Don't show a dialog every time the scripts dir is opened This should be moved to the documentation.
Review of attachment 221088 [details] [review]: Thanks, looks mostly good. ::: src/nautilus-special-location-bar.c @@ +72,3 @@ + if (message == NULL) { + gtk_widget_destroy (GTK_WIDGET (bar)); + return; I think you could remove this code, as you g_assert() in the no-message case of get_message_for_special_location() @@ +124,3 @@ +nautilus_special_location_bar_finalize (GObject *object) +{ + G_OBJECT_CLASS (nautilus_special_location_bar_parent_class)->finalize (object); This doesn't seem to be useful ::: src/nautilus-special-location-enum-types.h.in @@ +1,3 @@ +/*** BEGIN file-header ***/ +#ifndef NAUTILUS_SPECIAL_LOCATION_ENUM_TYPES_H +#define NAUTILUS_SPECIAL_LOCATION_ENUM_TYPES_H I'd rather have a general nautilus-enum-types shared for all the objects that need one, rather than a special one just for NautilusSpecialLocationBar. I also think it's cleaner to just generate the boilerplate completely using automake...[1] has an example for how to do this. [1] http://git.gnome.org/browse/empathy/tree/libempathy/Makefile.am#n179 ::: src/nautilus-view.c @@ +7635,3 @@ view); /* Translators: %s is a directory */ This comment isn't needed anymore.
Review of attachment 221089 [details] [review]: Looks good, but we should at least file a bug against gnome-user-docs requesting this text to be added to the guide.
Created attachment 221139 [details] [review] Add a clue bar to special locations like Templates and scripts
Review of attachment 221139 [details] [review]: Looks good!
*** Bug 680321 has been marked as a duplicate of this bug. ***