After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 84148 - gnome_help_display_with_doc_id() doesn't use doc_id
gnome_help_display_with_doc_id() doesn't use doc_id
Status: RESOLVED FIXED
Product: libgnome
Classification: Deprecated
Component: general
unspecified
Other other
: High normal
: ---
Assigned To: libgnome maintainer
libgnome maintainer
Depends on:
Blocks:
 
 
Reported: 2002-06-04 17:57 UTC by Damon Chaplin
Modified: 2006-01-01 21:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Proposed patch (732 bytes, patch)
2005-01-12 13:33 UTC, Muktha 		committed Details | Review
Additional patch (1.18 KB, patch)
2005-12-22 07:28 UTC, Nickolay V. Shmyrev 		none Details | Review
Probably better patch (1.64 KB, patch)
2005-12-22 07:32 UTC, Nickolay V. Shmyrev 		committed Details | Review

Description Damon Chaplin 2002-06-04 17:57:38 UTC 
gnome_help_display_with_doc_id() takes a doc_id parameter, which the
documentation describes as the 'document identifier'.

But it doesn't use it at all. That is pretty awful.
Comment 1 Muktha 2005-01-12 13:33:54 UTC 
Created attachment 35894 [details] [review]
Proposed patch
Comment 2 Kjartan Maraas 2005-01-14 09:43:27 UTC 
Removing API keyword and adding PATCH since this isn't about changing/adding API
bug actually using arguments passed to the function.
Comment 3 Kjartan Maraas 2005-08-12 11:19:00 UTC 
Commiting this.
Comment 4 Nickolay V. Shmyrev 2005-12-16 15:54:44 UTC 
Hey guys, you've broke ABI with this patch. Look at the bug 324141
Comment 5 Nickolay V. Shmyrev 2005-12-22 07:28:01 UTC 
Created attachment 56285 [details] [review]
Additional patch

Previously gnome_help_display was passing NULL as doc_id and it was converted to "", now it is converted to "program_name" and this change breaks document search.

I propose to commit that patch to quickly fix gnome_help_display behaviour.
Comment 6 Nickolay V. Shmyrev 2005-12-22 07:32:41 UTC 
Created attachment 56286 [details] [review]
Probably better patch

This patch tries to completely revert ABI breakage. Probably there were external programs using this display_document_with_id, and they can rely on id == NULL behaviour also as gnome_help_display do.
Comment 7 Kjartan Maraas 2006-01-01 21:45:37 UTC 
Commited the last patch.