GNOME Bugzilla – Bug 84147
Check background pixmap isn't kept around when unnecessary
Last modified: 2005-03-10 15:18:36 UTC
I added a check for is_nautilus_running() just before setting the background. I should probably have freed the pixmap if we didn't need it, as it wastes a few MB. in applier.c, set_root_pixmap()
This problem is still there I guess?
SPAM as discussed last night. Search for 'SPAM as discussed last night' to catch these all and delete them. :)
Could you attach a patch for it?
When is freeing the pixmap possible? Do we allocate it twice in the nautilus-is-running case? We still need a pixmap even when nautilus isn't running I guess. Just trying to get some more background (no pun intended) :)
Could someone please give a hint as to whether this still is relevant in 2.6.x?
It looks like it might be. I don't know what that bit of code is doing exactly, but it is in libbackground/. The libbackground tree is also pulled into nautilus itself as well, I believe.
Damon, could you give a more detailed explanation of the problem?
This is related to my fix for bug 74311. I fixed it so that if nautilus is running gnome-settings-daemon doesn't set the pixmap (as nautilus will handle that). But it may keep it around unnecessarily. It looks like this may still be the case. I don't really understand the code that well, so I didn't want to change it too much. I had hoped that whoever maintained gnome-settings-daemon would know what to do.
*** This bug has been marked as a duplicate of 169347 ***