After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 82478 - Fractal Explorer: Undo/Redo Zoom don't always work
Fractal Explorer: Undo/Redo Zoom don't always work
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
1.x
Other All
: Normal minor
: 2.0
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2002-05-21 10:49 UTC by Maurits Rijk
Modified: 2004-01-11 17:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes some zoom undo buffer issues in Fractal Explorer (2.19 KB, patch)
2004-01-11 02:32 UTC, Pedro Gimeno
none Details | Review

Description Maurits Rijk 2002-05-21 10:49:57 UTC
The Undo/Redo Zoom buttons don't work after selecting 'Step In' or 'Step out'.

To reproduce:
- Start Fractal Explorer plugin
- Click 'Step In' button
- Click 'Redo Zoom' button: nothing happens
Comment 1 Pedro Gimeno 2004-01-11 02:31:10 UTC
If I understood this report properly, Maurits meant that when pressing
"Zoom In" then "Undo", the latter action has no effect. The following
patch solves this issue.
Comment 2 Pedro Gimeno 2004-01-11 02:32:19 UTC
Created attachment 23219 [details] [review]
Fixes some zoom undo buffer issues in Fractal Explorer
Comment 3 Sven Neumann 2004-01-11 02:49:58 UTC
Hmm, Undo doesn't affect the zoom ratio on the GIMP canvas so why
should it do here? IMO the right fix is to make changes to the zoom
ratio not undoable. But I might have completely misunderstood this report.
Comment 4 Pedro Gimeno 2004-01-11 15:51:46 UTC
The plug-in has its own zoom undo/redo buttons, and that's what is
broken only in the case of zoom in / zoom out. When selecting a window
to zoom in the preview, the zoom undo/redo buttons work as expected.
Comment 5 Sven Neumann 2004-01-11 16:17:14 UTC
Good. Then let's apply your patch.
Comment 6 Pedro Gimeno 2004-01-11 17:40:13 UTC
2004-01-11  Pedro Gimeno

	* app/core/gimpdrawable-preview.c (gimp_drawable_preview_scale):
	Apply threshold to alpha in the same way as it is applied to the
	image in indexed mode. Fixes bug #115793, at least until the
	alpha thresholds in indexed images are removed.

	* plug-ins/FractalExplorer/Display.c: Fix zoom undo handling
	issues. Closes bug #82478.