After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 81702 - not loading tiffs right on LE box
not loading tiffs right on LE box
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Mac OS
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 80435
 
 
Reported: 2002-05-14 05:17 UTC by jacob berkman
Modified: 2010-07-10 04:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot of eog (243.70 KB, image/png)
2002-05-14 05:17 UTC, jacob berkman
  Details
the patch (1.11 KB, patch)
2002-05-16 21:48 UTC, Matthias Clasen
none Details | Review

Description jacob berkman 2002-05-14 05:17:01 UTC
loading a BE tiff on a LE (PPC) box, it gets some of the colors wrong.
(see attached image)
Comment 1 jacob berkman 2002-05-14 05:17:33 UTC
Created attachment 8445 [details]
screenshot of eog
Comment 2 Matthias Clasen 2002-05-15 11:42:42 UTC
Could you verify if this also occurs with older versions of 
io-tiff.c ? The reason I'm 
asking is that I changed the latest
version (1.32) to directly copy stuff into the 
pixbuf instead of
dumping it into a separate buffer and copying individual 
samples
with TIFFGet[RGBA]. But since then I've found some hints in the
libtiff 
mailing list and bugzilla which seem to indicate that the
actual sample order used 
by the TIFFRGBAImage API depends on the
host endianness. 
Comment 3 jacob berkman 2002-05-15 17:43:11 UTC
actually i always get endianness wrong, and the PPC is BE isn't it?

i'll look at this tonight, thanks.
Comment 4 jacob berkman 2002-05-15 23:57:00 UTC
yep, updating to 1.31 and reinstalling the tiff loader makes it work.
Comment 5 Matthias Clasen 2002-05-16 07:05:44 UTC
Ok, I'll look into fixing this. Simply reverting to 1.31 is not 
good, since there is a 
number of robustness fixes in 1.32 in addition
to the problematic change.
Comment 6 Matthias Clasen 2002-05-16 21:47:11 UTC
Would you mind testing if the following patch (against io-tiff.c 1.32)
works on PPC ?
Comment 7 Matthias Clasen 2002-05-16 21:48:21 UTC
Created attachment 8520 [details] [review]
the patch
Comment 8 jacob berkman 2002-05-17 01:24:42 UTC
i tested this patch on x86 linux and ppc mac os with both LE and BE
tiffs, and it works.